From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760715AbZBMAsp (ORCPT ); Thu, 12 Feb 2009 19:48:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758709AbZBMAsY (ORCPT ); Thu, 12 Feb 2009 19:48:24 -0500 Received: from ns.suse.de ([195.135.220.2]:46160 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758633AbZBMAsY (ORCPT ); Thu, 12 Feb 2009 19:48:24 -0500 Date: Thu, 12 Feb 2009 16:45:31 -0800 From: Greg KH To: David Miller Cc: greg@kroah.com, randy.dunlap@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 9/9] staging/sxg: fix napi interface build Message-ID: <20090213004531.GA9791@suse.de> References: <20090212195133.GB16214@kroah.com> <20090212.145620.268233419.davem@davemloft.net> <20090212230846.GA25058@suse.de> <20090212.152205.81876086.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090212.152205.81876086.davem@davemloft.net> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 12, 2009 at 03:22:05PM -0800, David Miller wrote: > From: Greg KH > Date: Thu, 12 Feb 2009 15:08:46 -0800 > > > On Thu, Feb 12, 2009 at 02:56:20PM -0800, David Miller wrote: > > > From: Greg KH > > > Date: Thu, 12 Feb 2009 11:51:33 -0800 > > > > > > > On Wed, Feb 11, 2009 at 01:22:56PM -0800, Randy Dunlap wrote: > > > > > From: Randy Dunlap > > > > > > > > > > Fix staging/sxg napi interface calls: > > > > > > > > > > drivers/staging/sxg/sxg.c:1271: error: implicit declaration of function 'netif_rx_schedule_prep' > > > > > linux-next-20090209/drivers/staging/sxg/sxg.c:1272: error: implicit declaration of function '__netif_rx_schedule' > > > > > drivers/staging/sxg/sxg.c:1325: error: implicit declaration of function 'netif_rx_complete' > > > > > > > > As I count over 80 instances of netif_rx_complete in Linus's tree right > > > > now, I'm guesing this is due to a change from the netdev tree. Which is > > > > fine, but I'll wait until that gets merged with Linus to apply this > > > > patch. > > > > > > Well it means that it won't build in -next until the next merge > > > window. > > > > I can live with that :) > > > > Or is the new api already there and it's safe to make this change now? > > If you make the change, your driver will build in Linus's > tree. Just sed 's/netif_rx_/napi_/' for the lines the > above warning triggers on. Ah, sorry, didn't realize that. I'll go apply the patch now, sorry for the noise... greg k-h