From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Peter Feuerer <peter@piie.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Acer Aspire One fan control
Date: Fri, 13 Feb 2009 13:40:24 +0000 [thread overview]
Message-ID: <20090213134024.GA26549@srcf.ucam.org> (raw)
In-Reply-To: <cone.1234471033.988571.5384.1000@mentalhome>
On Thu, Feb 12, 2009 at 09:37:13PM +0100, Peter Feuerer wrote:
> Do you think it makes sense to add it as seperate kernelmodule or should I
> patch another module, e.g. the drivers/misc/acer-wmi.c module?
> Should I try also to add the functionality of the
> /proc/acpi/thermal_zone/THRM/* things in my first patch? Or just submit the
> general functionality for controlling the fan and add additional things
> step by step?
That depends on how you're doing it. Is the code available somewhere? If
these io ports are also used by the firmware then you'll need to find
ACPI methods to call to perform the fan control. If there aren't any
then it's not safe to have a driver to do this.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-02-13 13:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 20:37 Acer Aspire One fan control Peter Feuerer
2009-02-12 21:03 ` Ralf Hildebrandt
2009-02-12 21:14 ` Peter Feuerer
2009-03-09 10:54 ` Maxim Levitsky
2009-02-13 10:35 ` Thomas Renninger
2009-02-13 19:34 ` Peter Feuerer
2009-02-13 13:40 ` Matthew Garrett [this message]
2009-02-13 18:59 ` Peter Feuerer
2009-02-13 19:18 ` Matthew Garrett
2009-02-13 19:45 ` Peter Feuerer
2009-02-27 18:58 ` [PATCH] acerhdf: " Peter Feuerer
[not found] ` <1235763653.24506.6.camel@localhost>
2009-02-28 18:58 ` Peter Feuerer
2009-03-01 14:38 ` Matthew Garrett
2009-03-26 22:22 ` Peter Feuerer
2009-04-01 12:44 ` Peter Feuerer
2009-04-12 20:49 ` Peter Feuerer
2009-04-04 10:51 ` Peter Feuerer
2009-03-01 15:27 ` Ed Tomlinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090213134024.GA26549@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@piie.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox