Linux 2.6.27.17

Linux 2.6.27.17

[Greg KH]

Here's the announcement of the 2.6.27.17 kernel.

It reverts one patch in the 2.6.27.16 kernel release, which caused an
instant oops if you happened to have a laptop with a docking station.
Many thanks to David Engel for pointing out the problem.

I'll also be replying to this message with a copy of the patch between
2.6.27.16 and 2.6.27.17

The updated 2.6.27.y git tree can be found at:
        git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.27.y.git
and can be browsed at the normal kernel.org git web browser:
        http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.27.y.git;a=summary

thanks,

greg k-h

------------

 Makefile            |    2 +-
 drivers/acpi/dock.c |    8 +-------
 2 files changed, 2 insertions(+), 8 deletions(-)

Greg Kroah-Hartman (2):
      Revert "ACPI: dock: Don't eval _STA on every show_docked sysfs read"
      Linux 2.6.27.17

Re: Linux 2.6.27.17

[Greg KH]

diff --git a/Makefile b/Makefile
index d398828..104fb0f 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 VERSION = 2
 PATCHLEVEL = 6
 SUBLEVEL = 27
-EXTRAVERSION = .16
+EXTRAVERSION = .17
 NAME = Trembling Tortoise
 
 # *DOCUMENTATION*
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index eab790f..e28469e 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -691,14 +691,8 @@ fdd_out:
 static ssize_t show_docked(struct device *dev,
 			   struct device_attribute *attr, char *buf)
 {
-	struct acpi_device *tmp;
-
-	struct dock_station *dock_station = *((struct dock_station **)
-		dev->platform_data);
+	return snprintf(buf, PAGE_SIZE, "%d\n", dock_present(dock_station));
 
-	if (ACPI_SUCCESS(acpi_bus_get_device(dock_station->handle, &tmp)))
-		return snprintf(buf, PAGE_SIZE, "1\n");
-	return snprintf(buf, PAGE_SIZE, "0\n");
 }
 static DEVICE_ATTR(docked, S_IRUGO, show_docked, NULL);
 

Re: Linux 2.6.27.17

[Michael Tokarev]

Greg KH wrote:
> Here's the announcement of the 2.6.27.17 kernel.
> 
> It reverts one patch in the 2.6.27.16 kernel release, which caused an
> instant oops if you happened to have a laptop with a docking station.
> Many thanks to David Engel for pointing out the problem.

> Greg Kroah-Hartman (2):
>       Revert "ACPI: dock: Don't eval _STA on every show_docked sysfs read"
>       Linux 2.6.27.17

I wonder if the same should be done with 2.6.28.5...

/mjt

Re: Linux 2.6.27.17

[Greg KH]

On Fri, Feb 13, 2009 at 10:46:26AM +0300, Michael Tokarev wrote:
> Greg KH wrote:
> > Here's the announcement of the 2.6.27.17 kernel.
> > 
> > It reverts one patch in the 2.6.27.16 kernel release, which caused an
> > instant oops if you happened to have a laptop with a docking station.
> > Many thanks to David Engel for pointing out the problem.
> 
> > Greg Kroah-Hartman (2):
> >       Revert "ACPI: dock: Don't eval _STA on every show_docked sysfs read"
> >       Linux 2.6.27.17
> 
> I wonder if the same should be done with 2.6.28.5...

No, commit db350b084dc2cf816288643861ce07b0562dd723 is already in
2.6.28, which is needed in order to have the patch that we reverted in
2.6.27.17 work properly.  So it's safe to keep this in the .28-stable
tree.

Unless you or anyone else is having problems with it?  If so, please let
me know.

thanks,

greg k-h

Re: Linux 2.6.27.17

[David Engel]

On Fri, Feb 13, 2009 at 10:46:26AM +0300, Michael Tokarev wrote:
> Greg KH wrote:
> > Here's the announcement of the 2.6.27.17 kernel.
> > 
> > It reverts one patch in the 2.6.27.16 kernel release, which caused an
> > instant oops if you happened to have a laptop with a docking station.
> > Many thanks to David Engel for pointing out the problem.
> 
> > Greg Kroah-Hartman (2):
> >       Revert "ACPI: dock: Don't eval _STA on every show_docked sysfs read"
> >       Linux 2.6.27.17
> 
> I wonder if the same should be done with 2.6.28.5...

I haven't updated most of my systems to 2.6.28 yet.  I just gave
2.6.28.5 a try on my laptop, though.  It does not have the show_docked
oops I had with 2.6.27.16.

David
-- 
David Engel
david@istwok.net