Re: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__

[Ingo Molnar <mingo@elte.hu>]

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Ingo Molnar wrote:
>> From beb6943d8df7ce9278282101af4e0f6f7b648451 Mon Sep 17 00:00:00 2001
>> From: Ingo Molnar <mingo@elte.hu>
>> Date: Fri, 13 Feb 2009 13:36:47 +0100
>> Subject: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__
>>   
>
> I think this is wrong in principle.  There should never be a reason to  
> include a non-_types.h into asm.
>
> (Fine as a build fix, of course.)

Agreed - but it needs fixes to the .S files, these assembly files
include pgtable.h or page.h:

arch/x86/boot/compressed/head_32.S
arch/x86/boot/compressed/head_64.S
arch/x86/boot/header.S
arch/x86/kernel/acpi/realmode/wakeup.S
arch/x86/kernel/acpi/wakeup_32.S
arch/x86/kernel/acpi/wakeup_64.S
arch/x86/kernel/efi_stub_32.S
arch/x86/kernel/entry_32.S
arch/x86/kernel/entry_64.S
arch/x86/kernel/head_32.S
arch/x86/kernel/head_64.S
arch/x86/kernel/relocate_kernel_32.S
arch/x86/kernel/relocate_kernel_64.S
arch/x86/kernel/trampoline_32.S
arch/x86/kernel/trampoline_64.S
arch/x86/kernel/vmlinux_32.lds.S
arch/x86/kernel/vmlinux_64.lds.S
arch/x86/lib/getuser.S
arch/x86/power/hibernate_asm_32.S
arch/x86/power/hibernate_asm_64.S
arch/x86/xen/xen-head.S

	Ingo