Re: [PATCH 1/5]: drm: ati_pcigart: Do not access I/O MEM space using pointer derefs.

[David Miller <davem@davemloft.net>]

From: Dave Airlie <airlied@gmail.com>
Date: Sat, 14 Feb 2009 17:42:02 +1000

> On Sat, Feb 14, 2009 at 4:09 PM, David Miller <davem@davemloft.net> wrote:
> > 1) Mis-sizes the GART table save buffer, it uses PAGE_SIZE instead
> >   of the constant 4096 to determine how many GART entries there
> >   are.  The PCI GART entries map 4096 bytes, always.  So using
> >   getpagesize() is wrong.  (see RADEONDRIGetPciAperTableSize)
> >
> >   I have this fixed in my local tree.
> 
> Oops.
> 
> > 2) It doesn't check the surface byte swapping settings, so it
> >   could be saving in one byte order and restoing in another.
> >
> >   I guess we could force RADEON_SURFACE_CNTL to zero around
> >   the two memcpy()'s done in radeon_driver.c
> 
> Might be a good plan.

I have patches for both of these things written, will submit
to the xorg-driver-ati list.

I also have a cunning plan to work around the surface swapping
GART issue in the DRM, will try that out right now.