public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Len Brown <lenb@kernel.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Arve Hjønnevåg" <arve@android.com>, "Greg KH" <gregkh@suse.de>,
	"Ingo Molnar" <mingo@elte.hu>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Pavel Machek" <pavel@ucw.cz>,
	"pm list" <linux-pm@lists.linux-foundation.org>,
	"Arjan van de Ven" <arjan@linux.intel.com>,
	"Alan Jenkins" <alan-jenkins@tuffmail.co.uk>,
	"Masami Hiramatsu" <mhiramat@redhat.com>,
	"Andrey Borzenkov" <arvidjaar@mail.ru>
Subject: [PATCH 2/9] PM/resume: wait for device probing to finish
Date: Sat, 14 Feb 2009 02:00:19 +0100	[thread overview]
Message-ID: <200902140200.21022.rjw@sisk.pl> (raw)
In-Reply-To: <200902140157.40869.rjw@sisk.pl>

From: Arjan van de Ven <arjan@linux.intel.com>

the resume code does not currently wait for device probing to finish.
Even without async function calls this is dicey and not correct,
but with async function calls during the boot sequence this is going
to get hit more...

This patch adds the synchronization using the newly introduced helper.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 kernel/power/disk.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

Index: linux-2.6/kernel/power/disk.c
===================================================================
--- linux-2.6.orig/kernel/power/disk.c
+++ linux-2.6/kernel/power/disk.c
@@ -595,6 +595,12 @@ static int software_resume(void)
 	unsigned int flags;
 
 	/*
+	 * If the user said "noresume".. bail out early.
+	 */
+	if (noresume)
+		return 0;
+
+	/*
 	 * name_to_dev_t() below takes a sysfs buffer mutex when sysfs
 	 * is configured into the kernel. Since the regular hibernate
 	 * trigger path is via sysfs which takes a buffer mutex before
@@ -610,6 +616,11 @@ static int software_resume(void)
 			mutex_unlock(&pm_mutex);
 			return -ENOENT;
 		}
+		/*
+		 * Some device discovery might still be in progress; we need
+		 * to wait for this to finish.
+		 */
+		wait_for_device_probe();
 		swsusp_resume_device = name_to_dev_t(resume_file);
 		pr_debug("PM: Resume from partition %s\n", resume_file);
 	} else {

  parent reply	other threads:[~2009-02-14  1:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-14  0:57 [PATCH 0/9] PM: Fixes related to suspend and hibernation for 2.6.29 Rafael J. Wysocki
2009-02-14  0:59 ` [PATCH 1/9] Consolidate driver_probe_done() loops into one place Rafael J. Wysocki
2009-02-14  1:47   ` Greg KH
2009-02-14  1:00 ` Rafael J. Wysocki [this message]
2009-02-14  1:48   ` [PATCH 2/9] PM/resume: wait for device probing to finish Greg KH
2009-02-14  1:01 ` [PATCH 3/9] PM/hibernate: fix "swap breaks after hibernation failures" Rafael J. Wysocki
2009-02-14  1:02 ` [PATCH 4/9] PM: fix build for CONFIG_PM unset Rafael J. Wysocki
2009-02-14  1:03 ` [PATCH 5/9] swsusp: dont fiddle with swappiness Rafael J. Wysocki
2009-02-14  1:04 ` [PATCH 6/9] swsusp: clean up shrink_all_zones() Rafael J. Wysocki
2009-02-14  1:05 ` [PATCH 7/9] PM: Fix pm_notifiers during user mode hibernation Rafael J. Wysocki
2009-02-14  1:06 ` [PATCH 8/9] PM: Wait for console in resume Rafael J. Wysocki
2009-02-14  1:07 ` [PATCH 9/9] PM: Fix suspend_console and resume_console to use only one semaphore Rafael J. Wysocki
2009-02-21  4:41 ` [PATCH 0/9] PM: Fixes related to suspend and hibernation for 2.6.29 Len Brown
2009-02-21  9:38   ` Rafael J. Wysocki
2009-02-21 18:29     ` Greg KH
2009-02-21 19:32       ` Arjan van de Ven
2009-02-21 19:48         ` Greg KH
2009-02-21 22:18           ` Linus Torvalds
2009-02-22  2:47             ` Len Brown
2009-02-22 10:07             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902140200.21022.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=arjan@linux.intel.com \
    --cc=arve@android.com \
    --cc=arvidjaar@mail.ru \
    --cc=gregkh@suse.de \
    --cc=hannes@cmpxchg.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=pavel@ucw.cz \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox