From: Andres Salomon <dilinger@queued.net>
To: Alessandro Zummo <azummo-lists@towertech.it>
Cc: jordan@cosmicpenguin.net, "David Brownell" <david-b@pacbell.net>,
linux-geode@lists.infradead.org, dsaxena@laptop.org,
"Martin-Éric Racine" <q-funk@iki.fi>,
lkml <linux-kernel@vger.kernel.org>,
rpurdie@rpsys.net, "Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] AMD Geode CS5535/5536 GPIO driver
Date: Sat, 14 Feb 2009 17:38:11 -0500 [thread overview]
Message-ID: <20090214173811.4d9a0957@ephemeral> (raw)
In-Reply-To: <20090214230235.5a29487f@i1501.lan.towertech.it>
On Sat, 14 Feb 2009 23:02:35 +0100
Alessandro Zummo <azummo-lists@towertech.it> wrote:
> On Sat, 14 Feb 2009 15:27:19 -0500
> Andres Salomon <dilinger@queued.net> wrote:
>
> > Sorry, I'm just now getting around to looking at this. Why did we
> > move it from cs553x-gpio.c to geode_32.c? I have a lemote
> > (longsoon-based) which uses cs5536:
>
> I've been suggested to move it within geode_32. the driver is
> probably pretty geode specific anyhow.
>
If the whole point is to make the cs553x GPIO stuff portable (and to use
the portable API), then what's the point if we know that it can/will
be used by non-x86 platforms?
We already have a cs553x GPIO char device, a geode GPIO lib that
works (but has flaws).. I'm all for creating The One True CS553x GPIO
API, but I'd consider something that's geode (and x86)-specific to be
a waste of time.
next prev parent reply other threads:[~2009-02-14 22:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 15:10 [PATCH] AMD Geode CS5535/5536 GPIO driver Alessandro Zummo
2009-02-06 0:12 ` David Brownell
2009-02-06 9:16 ` Alessandro Zummo
2009-02-15 22:47 ` Jordan Crouse
2009-02-14 20:27 ` Andres Salomon
2009-02-14 22:02 ` Alessandro Zummo
2009-02-14 22:38 ` Andres Salomon [this message]
2009-02-14 22:54 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090214173811.4d9a0957@ephemeral \
--to=dilinger@queued.net \
--cc=azummo-lists@towertech.it \
--cc=david-b@pacbell.net \
--cc=dsaxena@laptop.org \
--cc=hpa@zytor.com \
--cc=jordan@cosmicpenguin.net \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=q-funk@iki.fi \
--cc=rpurdie@rpsys.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox