Re: [PATCH] AMD Geode CS5535/5536 GPIO driver

Andres Salomon
2009-02-14T20:27:37Z

Sorry, I'm just now getting around to looking at this. Why did we move it
from cs553x-gpio.c to geode_32.c? I have a lemote (longsoon-based) which
uses cs5536:

Linux debian 2.6.27.1 #193 Mon Jan 5 11:14:50 CST 2009 mips64 GNU/Linux

system type : lemote-notebook
processor : 0
cpu model : ICT Loongson-2 V0.3 FPU V0.1
BogoMIPS : 132.09
wait instruction : yes
microsecond timers : yes
tlb_entries : 64
extra interrupt vector : no
hardware watchpoint : no
ASEs implemented :
shadow register sets : 1
core : 0
VCED exceptions : not available
VCEI exceptions : not available

00:07.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 10)
00:08.0 VGA compatible controller: Silicon Motion, Inc. SM712 LynxEM+ (rev b0)
00:09.0 USB Controller: NEC Corporation USB (rev 44)
00:09.1 USB Controller: NEC Corporation USB 2.0 (rev 05)
00:0e.0 ISA bridge: Advanced Micro Devices [AMD] CS5536 [Geode companion] ISA (rev 03)
00:0e.2 IDE interface: Advanced Micro Devices [AMD] CS5536 [Geode companion] IDE (rev 01)
00:0e.3 Multimedia audio controller: Advanced Micro Devices [AMD] CS5536 [Geode companion] Audio (rev 01)
00:0e.4 USB Controller: Advanced Micro Devices [AMD] CS5536 [Geode companion] OHC (rev 02)
00:0e.5 USB Controller: Advanced Micro Devices [AMD] CS5536 [Geode companion] EHC (rev 02)
00:0e.6 USB Controller: Advanced Micro Devices [AMD] CS5536 [Geode companion] UDC (rev 02)
00:0e.7 USB Controller: Advanced Micro Devices [AMD] CS5536 [Geode companion] UOC (rev 02)

This leads me to believe that the gpio framework should not be
architecture-specific (nor geode-specific).

On Thu, 5 Feb 2009 16:10:07 +0100
Alessandro Zummo <azummo-lists@towertech.it> wrote:

>
>
> A GPIO driver for the AMD Geode CS5535/5536 Companion Devices.
>
> In the release 2 I've addressed all the concerns expressed by the
> various subsys maintainers involved.
>
> --- …