Re: [PATCH] AMD Geode CS5535/5536 GPIO driver

Jordan Crouse
2009-02-15T22:56:23Z

Alessandro Zummo wrote:
> On Thu, 5 Feb 2009 16:12:20 -0800
> David Brownell <david-b@pacbell.net> wrote:
>
>> Unless this hardware misbehaves when both output and input
>> modes are enabled (e.g. in the window between those two calls),
>> I'd suggest just not clearing INPUT_ENABLE. It's legit to
>> ask for the *actual* value of an output line, e.g. for when
>> it uses open drain mode. (And didn't this hardware have an
>> option for open drain GPIO signaling?)
>
> seems reasonable,
> I'll let the Geode people decide what to do here...

Sorry, I'm just getting around to answering this. I don't recall any
situation where the hardware would mis-behave, but you never know with
this bit of silicon.

I say leave them both on, and revisit it if you get flamed.

Jordan