Re: [PATCH] AMD Geode CS5535/5536 GPIO driver

Andres Salomon
2009-02-14T22:38:25Z

On Sat, 14 Feb 2009 23:02:35 +0100
Alessandro Zummo <azummo-lists@towertech.it> wrote:

> On Sat, 14 Feb 2009 15:27:19 -0500
> Andres Salomon <dilinger@queued.net> wrote:
>
> > Sorry, I'm just now getting around to looking at this. Why did we
> > move it from cs553x-gpio.c to geode_32.c? I have a lemote
> > (longsoon-based) which uses cs5536:
>
> I've been suggested to move it within geode_32. the driver is
> probably pretty geode specific anyhow.
>

If the whole point is to make the cs553x GPIO stuff portable (and to use
the portable API), then what's the point if we know that it can/will
be used by non-x86 platforms?

We already have a cs553x GPIO char device, a geode GPIO lib that
works (but has flaws).. I'm all for creating The One True CS553x GPIO
API, but I'd consider something that's geode (and x86)-specific to be
a waste of time.