[PATCH] Declare PIO_CMAP/GIO_CMAP as compatbile ioctls.

[PATCH] Declare PIO_CMAP/GIO_CMAP as compatbile ioctls.

[Bill Nottingham]

Otherwise, these don't work when called from 32-bit userspace on 64-bit kernels.
---
 fs/compat_ioctl.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index 5235c67..9ee71a0 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -1937,6 +1937,8 @@ ULONG_IOCTL(SET_BITMAP_FILE)
 /* Big K */
 COMPATIBLE_IOCTL(PIO_FONT)
 COMPATIBLE_IOCTL(GIO_FONT)
+COMPATIBLE_IOCTL(PIO_CMAP)
+COMPATIBLE_IOCTL(GIO_CMAP)
 ULONG_IOCTL(KDSIGACCEPT)
 COMPATIBLE_IOCTL(KDGETKEYCODE)
 COMPATIBLE_IOCTL(KDSETKEYCODE)
-- 
1.6.1.2

Re: [PATCH] Declare PIO_CMAP/GIO_CMAP as compatbile ioctls.

[Jiri Kosina]

On Tue, 10 Feb 2009, Bill Nottingham wrote:

> Otherwise, these don't work when called from 32-bit userspace on 64-bit kernels.
> ---
>  fs/compat_ioctl.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
> index 5235c67..9ee71a0 100644
> --- a/fs/compat_ioctl.c
> +++ b/fs/compat_ioctl.c
> @@ -1937,6 +1937,8 @@ ULONG_IOCTL(SET_BITMAP_FILE)
>  /* Big K */
>  COMPATIBLE_IOCTL(PIO_FONT)
>  COMPATIBLE_IOCTL(GIO_FONT)
> +COMPATIBLE_IOCTL(PIO_CMAP)
> +COMPATIBLE_IOCTL(GIO_CMAP)
>  ULONG_IOCTL(KDSIGACCEPT)
>  COMPATIBLE_IOCTL(KDGETKEYCODE)
>  COMPATIBLE_IOCTL(KDSETKEYCODE)
> -- 
> 1.6.1.2

Alan, I am hesitant to consider this material implicitly applicable for 
trivial tree. Could you please give your Acked-by for it so that I can 
merge, or take it through your tree completely?

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] Declare PIO_CMAP/GIO_CMAP as compatbile ioctls.

[Andrew Morton]

On Wed, 11 Feb 2009 14:41:25 +0100 (CET) Jiri Kosina <jkosina@suse.cz> wrote:

> On Tue, 10 Feb 2009, Bill Nottingham wrote:
> 
> > Otherwise, these don't work when called from 32-bit userspace on 64-bit kernels.

Bill, please remember to add signoffs?  This should all be scripted.

> > ---
> >  fs/compat_ioctl.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
> > index 5235c67..9ee71a0 100644
> > --- a/fs/compat_ioctl.c
> > +++ b/fs/compat_ioctl.c
> > @@ -1937,6 +1937,8 @@ ULONG_IOCTL(SET_BITMAP_FILE)
> >  /* Big K */
> >  COMPATIBLE_IOCTL(PIO_FONT)
> >  COMPATIBLE_IOCTL(GIO_FONT)
> > +COMPATIBLE_IOCTL(PIO_CMAP)
> > +COMPATIBLE_IOCTL(GIO_CMAP)
> >  ULONG_IOCTL(KDSIGACCEPT)
> >  COMPATIBLE_IOCTL(KDGETKEYCODE)
> >  COMPATIBLE_IOCTL(KDSETKEYCODE)
> > -- 
> > 1.6.1.2
> 
> Alan, I am hesitant to consider this material implicitly applicable for 
> trivial tree.

No, it isn't appropriate for the trivial tree.

> Could you please give your Acked-by for it so that I can 
> merge, or take it through your tree completely?

afaict this fix is needed all the way back to 2.6.tiny.  I merged it
with 2.6.29 intentions.  Also tagged as needed in 2.6.25.x and later.

Re: [PATCH] Declare PIO_CMAP/GIO_CMAP as compatbile ioctls.

[Bill Nottingham]

(dropping trivial@ and stable@ cc's)

Andrew Morton (akpm@linux-foundation.org) said: 
> On Wed, 11 Feb 2009 14:41:25 +0100 (CET) Jiri Kosina <jkosina@suse.cz> wrote:
> 
> > On Tue, 10 Feb 2009, Bill Nottingham wrote:
> > 
> > > Otherwise, these don't work when called from 32-bit userspace on 64-bit kernels.
> 
> Bill, please remember to add signoffs?  This should all be scripted.

I would have expected that that would be the default in 'git format-patch'.
Will keep note of that for the future.

> > Could you please give your Acked-by for it so that I can 
> > merge, or take it through your tree completely?
> 
> afaict this fix is needed all the way back to 2.6.tiny.  I merged it
> with 2.6.29 intentions.  Also tagged as needed in 2.6.25.x and later.

So, is there some way to do static analysis on the kernel source to
find *all* ioctls that aren't marked as compatible, and don't have
specific compat handlers?

Bill

Re: [PATCH] Declare PIO_CMAP/GIO_CMAP as compatbile ioctls.

[Andrew Morton]

On Mon, 16 Feb 2009 12:23:18 -0500 Bill Nottingham <notting@redhat.com> wrote:

> > > Could you please give your Acked-by for it so that I can 
> > > merge, or take it through your tree completely?
> > 
> > afaict this fix is needed all the way back to 2.6.tiny.  I merged it
> > with 2.6.29 intentions.  Also tagged as needed in 2.6.25.x and later.
> 
> So, is there some way to do static analysis on the kernel source to
> find *all* ioctls that aren't marked as compatible, and don't have
> specific compat handlers?

Not that I am aware of.  Julia Lawall might be able to cook up such
a thing.

[PATCH] Declare PIO_CMAP/GIO_CMAP as compatbile ioctls.

[Bill Nottingham]

Otherwise, these don't work when called from 32-bit userspace on 64-bit kernels.
---
 fs/compat_ioctl.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index 5235c67..9ee71a0 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -1937,6 +1937,8 @@ ULONG_IOCTL(SET_BITMAP_FILE)
 /* Big K */
 COMPATIBLE_IOCTL(PIO_FONT)
 COMPATIBLE_IOCTL(GIO_FONT)
+COMPATIBLE_IOCTL(PIO_CMAP)
+COMPATIBLE_IOCTL(GIO_CMAP)
 ULONG_IOCTL(KDSIGACCEPT)
 COMPATIBLE_IOCTL(KDGETKEYCODE)
 COMPATIBLE_IOCTL(KDSETKEYCODE)
-- 
1.6.1.2

Re: [PATCH] Declare PIO_CMAP/GIO_CMAP as compatbile ioctls.

[Bill Nottingham]

Bill Nottingham (notting@redhat.com) said: 
> Otherwise, these don't work when called from 32-bit userspace on 64-bit kernels.

Sorry about this last bit - git hiccup.

Bill