From: Florian Fainelli <florian@openwrt.org>
To: openwrt-devel@lists.openwrt.org
Cc: Michael Buesch <mb@bu3sch.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [OpenWrt-Devel] [PATCH] bcm47xx: Fix GPIO API return codes
Date: Sun, 15 Feb 2009 14:27:36 +0100 [thread overview]
Message-ID: <200902151427.39196.florian@openwrt.org> (raw)
In-Reply-To: <200902142127.19521.mb@bu3sch.de>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
Hi Michael,
Le Saturday 14 February 2009 21:27:19 Michael Buesch, vous avez écrit :
> The GPIO API is supposed to return 0 or a negative error code,
> but the SSB GPIO functions return the bitmask of the GPIO register.
> Fix this by ignoring the bitmask and always returning 0. The SSB GPIO
> functions can't fail.
At some point we might want to convert the existing board code to use gpiolib.
I will try to come up with a patch for this later this afternoon.
Otherwise, your patch looks good.
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-02-15 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 20:27 [PATCH] bcm47xx: Fix GPIO API return codes Michael Buesch
2009-02-15 13:27 ` Florian Fainelli [this message]
2009-02-15 14:22 ` [OpenWrt-Devel] " Michael Buesch
2009-02-18 0:29 ` Andrew Morton
2009-02-18 0:52 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902151427.39196.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=openwrt-devel@lists.openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox