From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756597AbZBPCVJ (ORCPT ); Sun, 15 Feb 2009 21:21:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755614AbZBPCUx (ORCPT ); Sun, 15 Feb 2009 21:20:53 -0500 Received: from yx-out-2324.google.com ([74.125.44.30]:2056 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755557AbZBPCUv (ORCPT ); Sun, 15 Feb 2009 21:20:51 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding; b=t6DnAQ96iV8QbRJK0zv0EPkSFAdSp3ML1BEYl1sRnTsZ4UqSRbCFbYzz4FWLhHmG5F Ad1m6d/uV2CLurRVFfKcGCfwANh2Ha0foLeV4grIqa87dNTelMuMZjNAtBt1CgDs/XLB R6GBoGfwT5ijE++DBmIWIalH5dnjK720qgsZE= Date: Sun, 15 Feb 2009 20:20:47 -0600 From: Jay Cliburn To: Hannes Eder Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/43] drivers/net/atlx: fix sparse warnings: fix signedness Message-ID: <20090215202047.4e19ebef@osprey.hogchain.net> In-Reply-To: <20090214211508.23489.57841.stgit@vmbox.hanneseder.net> References: <20090214210940.23489.95001.stgit@vmbox.hanneseder.net> <20090214211508.23489.57841.stgit@vmbox.hanneseder.net> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.12.12; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 14 Feb 2009 22:15:17 +0100 Hannes Eder wrote: > Impact: While being at it: statics do not need to be initialized with 0. > > Fix this sparse warnings: > drivers/net/atlx/atl1.c:109:1: warning: incorrect type in initializer (different signedness) > drivers/net/atlx/atl2.c:2870:1: warning: incorrect type in initializer (different signedness) > drivers/net/atlx/atl2.c:2880:1: warning: incorrect type in initializer (different signedness) > drivers/net/atlx/atl2.c:2894:1: warning: incorrect type in initializer (different signedness) > drivers/net/atlx/atl2.c:2904:1: warning: incorrect type in initializer (different signedness) > drivers/net/atlx/atl2.c:2913:1: warning: incorrect type in initializer (different signedness) > > Signed-off-by: Hannes Eder Acked-by: Jay Cliburn > --- > drivers/net/atlx/atl1.c | 2 +- > drivers/net/atlx/atl2.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c > index c0ceee0..43fc1b2 100644 > --- a/drivers/net/atlx/atl1.c > +++ b/drivers/net/atlx/atl1.c > @@ -105,7 +105,7 @@ > * Default Value: 100 (200us) > */ > static int __devinitdata int_mod_timer[ATL1_MAX_NIC+1] = ATL1_PARAM_INIT; > -static int num_int_mod_timer; > +static unsigned int num_int_mod_timer; > module_param_array_named(int_mod_timer, int_mod_timer, int, > &num_int_mod_timer, 0); > MODULE_PARM_DESC(int_mod_timer, "Interrupt moderator timer"); > diff --git a/drivers/net/atlx/atl2.c b/drivers/net/atlx/atl2.c > index bc39449..9fe06c3 100644 > --- a/drivers/net/atlx/atl2.c > +++ b/drivers/net/atlx/atl2.c > @@ -2854,7 +2854,7 @@ static void atl2_force_ps(struct atl2_hw *hw) > #else > #define ATL2_PARAM(X, desc) \ > static int __devinitdata X[ATL2_MAX_NIC+1] = ATL2_PARAM_INIT; \ > - static int num_##X = 0; \ > + static unsigned int num_##X; \ > module_param_array_named(X, X, int, &num_##X, 0); \ > MODULE_PARM_DESC(X, desc); > #endif > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html