public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: "Sachin P. Sant" <sachinp@in.ibm.com>
Cc: linux-usb@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Kay Sievers <kay.sievers@vrfy.org>, Greg KH <greg@kroah.com>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Patch - Next] [USB/FHCI] use dev_name() in place of bus_id.
Date: Mon, 16 Feb 2009 16:48:55 +0300	[thread overview]
Message-ID: <20090216134855.GA26671@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <49996CBB.7040007@in.ibm.com>

On Mon, Feb 16, 2009 at 07:10:11PM +0530, Sachin P. Sant wrote:
> Replace references to bus_id with dev_name() to fix fhci driver build break.
>
> drivers/usb/host/fhci-hcd.c:586: error: struct device has no member named bus_id
> drivers/usb/host/fhci-hcd.c:653: error: struct device has no member named bus_id
> drivers/usb/host/fhci-dbg.c:111: error: struct device has no member named bus_id
>
> Signed-off-by: Sachin Sant <sachinp@in.ibm.com>

Acked-by: Anton Vorontsov <avorontsov@ru.mvista.com>

Thanks for catching this.

> ---
> 
> diff -Naurp a/drivers/usb/host/fhci-dbg.c b/drivers/usb/host/fhci-dbg.c
> --- a/drivers/usb/host/fhci-dbg.c	2009-02-14 05:01:30.000000000 +0530
> +++ b/drivers/usb/host/fhci-dbg.c	2009-02-16 18:19:25.000000000 +0530
> @@ -108,7 +108,7 @@ void fhci_dfs_create(struct fhci_hcd *fh
>  {
>  	struct device *dev = fhci_to_hcd(fhci)->self.controller;
>  
> -	fhci->dfs_root = debugfs_create_dir(dev->bus_id, NULL);
> +	fhci->dfs_root = debugfs_create_dir(dev_name(dev), NULL);
>  	if (!fhci->dfs_root) {
>  		WARN_ON(1);
>  		return;
> diff -Naurp a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
> --- a/drivers/usb/host/fhci-hcd.c	2009-02-14 05:01:30.000000000 +0530
> +++ b/drivers/usb/host/fhci-hcd.c	2009-02-16 18:19:00.000000000 +0530
> @@ -583,7 +583,7 @@ static int __devinit of_fhci_probe(struc
>  	if (sprop && strcmp(sprop, "host"))
>  		return -ENODEV;
>  
> -	hcd = usb_create_hcd(&fhci_driver, dev, dev->bus_id);
> +	hcd = usb_create_hcd(&fhci_driver, dev, dev_name(dev));
>  	if (!hcd) {
>  		dev_err(dev, "could not create hcd\n");
>  		return -ENOMEM;
> @@ -650,7 +650,7 @@ static int __devinit of_fhci_probe(struc
>  			}
>  		}
>  
> -		ret = gpio_request(gpio, dev->bus_id);
> +		ret = gpio_request(gpio, dev_name(dev));
>  		if (ret) {
>  			dev_err(dev, "failed to request gpio %d", i);
>  			goto err_gpios;


-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2009-02-16 13:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-16  6:20 linux-next: Tree for February 16 Stephen Rothwell
2009-02-16  8:54 ` next Feb 16 build break [usb/host/fhci-*] Sachin P. Sant
2009-02-16 10:13   ` Stephen Rothwell
2009-02-16 13:40     ` [Patch - Next] [USB/FHCI] use dev_name() in place of bus_id Sachin P. Sant
2009-02-16 13:48       ` Anton Vorontsov [this message]
2009-02-16 16:46 ` [PATCH -next] staging/phison: fix kconfig for clean build Randy Dunlap
2009-02-17  0:55 ` next-20090216: slqb Alexey Dobriyan
2009-02-17 10:27   ` Nick Piggin
2009-02-17 11:31     ` Pekka Enberg
2009-02-17 12:48       ` Peter Zijlstra
2009-02-17  9:55 ` linux-next: USB mouse won't work after resume Laurent Riffard
2009-02-17 10:35   ` Oliver Neukum
2009-02-17 13:37     ` Laurent Riffard
2009-02-17 15:12       ` Alan Stern
2009-02-17 20:42       ` Oliver Neukum
2009-02-17 21:05         ` Alan Stern
2009-02-18  9:51           ` Jiri Slaby
2009-02-18  0:31         ` Laurent Riffard
2009-02-18  8:47           ` Oliver Neukum
2009-02-18 16:51         ` Alan Stern
2009-02-18 17:06           ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090216134855.GA26671@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sachinp@in.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox