The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Kristof Provost <Kristof@sigsegv.be>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: buytenh@wantstofly.org, sylver.bruneau@googlemail.com
Subject: Compile error in drivers/watchdog/orion5x_wdt.c
Date: Mon, 16 Feb 2009 22:24:14 +0100	[thread overview]
Message-ID: <20090216212413.GB27134@nereid> (raw)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

drivers/watchdog/orion5x_wdt.c fails to compile with the following error:

  CC [M]  drivers/watchdog/orion5x_wdt.o
drivers/watchdog/orion5x_wdt.c:37: error: 'ORION5X_TCLK' undeclared here
(not in a function)
make[2]: *** [drivers/watchdog/orion5x_wdt.o] Error 1


I guess the problem is related to ebe35aff883496c07248df82c8576c3b6e84bbbe 
as it removed ORION5X_TLCK from arch/arm/mach-orion5x/include/mach/timex.h.
There are no other defines or uses of ORION5X_TLCK than in the watchdog.

I don't think simply restoring the define is the appropriate solution 
though. According to the commit log the value can be different for 
different hardware variants.

Regards,
Kristof Provost
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmZ2X0ACgkQUEZ9DhGwDuhBOgCfUubO6evdRalap8WSfF7k99I2
Bg8An1SPfFuueiU7Ndum9RNnIXLcdY7V
=qubX
-----END PGP SIGNATURE-----

                 reply	other threads:[~2009-02-16 21:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090216212413.GB27134@nereid \
    --to=kristof@sigsegv.be \
    --cc=buytenh@wantstofly.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sylver.bruneau@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox