Re: [PATCH 04/15] ftrace: break up ftrace_match_records into smaller components

Ingo Molnar
2009-02-17T10:34:26Z

* Steven Rostedt <rostedt@goodmis.org> wrote:

> +static void ftrace_match_records(char *buff, int len, int enable)
> +{
> + char *search;
> + struct ftrace_page *pg;
> + struct dyn_ftrace *rec;
> + int type;
> + unsigned long flag = enable ? FTRACE_FL_FILTER : FTRACE_FL_NOTRACE;
> + unsigned search_len;
> + int not;

Small style nit, the above looks better as:

> + unsigned int search_len;
> + struct ftrace_page *pg;
> + struct dyn_ftrace *rec;
> + unsigned long flag;
> + char *search;
> + int type;
> + int not;
> +
> + flag = enable ? FTRACE_FL_FILTER : FTRACE_FL_NOTRACE;

and this is what we do in other places of the tracing code.

(Also note the change of 'unsigned search_len' to 'unsigned int
search_len'.)

Ingo