Re: [PATCH 12/15] ftrace: add traceon traceoff commands to enable/disable the buffers

Ingo Molnar
2009-02-17T12:48:19Z

* Steven Rostedt <rostedt@goodmis.org> wrote:

>
> On Tue, 17 Feb 2009, Ingo Molnar wrote:
>
> >
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > + if (*count != -1)
> > > + (*count)--;
> >
> > minor nit: it's a tiny bit more compact as:
> >
> > > + if (*count != -1)
> > > + --*count;
>
> Doesn't that move the pointer? Cases like these, I prefer the parenthesis,
> because I get confused about C ordering.
>
> >
> > and this:
> >
> > > return register_tracer(&function_trace);
> > > }
> > >
> > > device_initcall(init_function_trace);
> > > +
> >
> > there should be no newline between device_initcall() and the
> > preceding function. (we can think of it as a late attribute of
> > the function, attached to the function. We do the same for
> > EXPORT_SYMBOL's too, etc.)
>
> OK,
>
> Do you want me to rebase, or just send out new "clean up" patches?

I already pulled (these are small details, not showstoppers),
please do a delta cleanup of those files.

( there's a few other instances of the same kind of problems -
please look at the whole file and try to figure out how to
make them look nicer. )

Ingo