Re: [PATCH 12/15] ftrace: add traceon traceoff commands to enable/disable the buffers

Ingo Molnar
2009-02-17T10:38:00Z

* Steven Rostedt <rostedt@goodmis.org> wrote:

> + if (*count != -1)
> + (*count)--;

minor nit: it's a tiny bit more compact as:

> + if (*count != -1)
> + --*count;

and this:

> return register_tracer(&function_trace);
> }
>
> device_initcall(init_function_trace);
> +

there should be no newline between device_initcall() and the
preceding function. (we can think of it as a late attribute of
the function, attached to the function. We do the same for
EXPORT_SYMBOL's too, etc.)

Ingo