From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755016AbZBPXRT (ORCPT ); Mon, 16 Feb 2009 18:17:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751706AbZBPXRL (ORCPT ); Mon, 16 Feb 2009 18:17:11 -0500 Received: from ozlabs.org ([203.10.76.45]:53353 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbZBPXRK (ORCPT ); Mon, 16 Feb 2009 18:17:10 -0500 From: Rusty Russell To: Peter Zijlstra Subject: Re: [PATCH 3/4] generic-smp: properly allocate the cpumasks Date: Tue, 17 Feb 2009 09:47:05 +1030 User-Agent: KMail/1.11.0 (Linux/2.6.27-11-generic; KDE/4.2.0; i686; ; ) Cc: Linus Torvalds , Nick Piggin , Jens Axboe , "Paul E. McKenney" , Ingo Molnar , Steven Rostedt , linux-kernel@vger.kernel.org, Oleg Nesterov References: <20090216163847.431174825@chello.nl> <20090216164114.609493567@chello.nl> In-Reply-To: <20090216164114.609493567@chello.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902170947.06133.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 17 February 2009 03:08:50 Peter Zijlstra wrote: > Its not deemed proper to have full cpumasks in data anymore, we have to > dynamically allocate them based on runtime determined dimensions of the > machine in question. Wow, thanks. But FYI I would have been happy with allocating them for each possible CPU, rather than doing the hotplug callback thing. If you really *can* have 4096 CPUS, I'm not so upset about spending 2M; it's when you've got 2 CPUs and the distro has set CONFIG_NR_CPUS=4096 that I care about. I'm not saying to fix it, I'm just saying you went beyond the call of duty. Kudos, Rusty.