Re: [PATCH] Fix vde network backend in user mode linux

["Américo Wang" <xiyou.wangcong@gmail.com>]

On Mon, Feb 16, 2009 at 02:23:45PM +0100, Luca Bigliardi wrote:
>On Mon, Feb 16, 2009 at 08:49 PM, Américo Wang wrote:
>
>> On Mon, Feb 16, 2009 at 01:38:46PM +0100, Jiri Kosina wrote:
>> >
>> >[ doesn't seem to be picked up by anyone into current -next nor -mmotm, 
>> >  but isn't appropriate for trivial; adding akpm to cc ]
>> >
>> >On Mon, 2 Feb 2009, Luca Bigliardi wrote:
>> >
>> >> * Replace kmalloc() with uml_kmalloc()
>> >>   (fix build failure)
>> 
>> 
>> Weird... I sent a patch for this several months ago! I thought
>> Jeff had already taken it... No?
>
>I did as well (in June/July 08 IIRC) through usermodelinux-devel mailing
>list but the patch didn't hit, so this time I've tried this way.

The problem is _not_ that I don't like you to fix it again, it _is_
that Jeff said he queued a same patch[1] but he didn't push it. :)

1. http://lkml.org/lkml/2008/7/23/142


>
>> >> * Remove unnecessary UM_KERN_INFO in printk()
>> >>   (don't display '<6>' while printing info)
>> 
>> But why only this one, not other UM_KERN_INFO in the same file?
>
>Other lines are preceded by a 'new_text_line' so vprintk 'eats' the token.

Ok then, thank you!

Reviewed-by: WANG Cong <wangcong@zeuux.org>


-- 
"Against stupidity, the gods themselves, contend in vain."