From: Greg KH <greg@kroah.com>
To: Mike Murphy <mamurph@cs.clemson.edu>
Cc: Oliver Neukum <oliver@neukum.org>,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: xpad.c - Xbox 360 wireless and sysfs support
Date: Tue, 17 Feb 2009 10:39:54 -0800 [thread overview]
Message-ID: <20090217183954.GA22850@kroah.com> (raw)
In-Reply-To: <5aa163d00902171027o139ba751r8103f948f3f492bb@mail.gmail.com>
On Tue, Feb 17, 2009 at 01:27:48PM -0500, Mike Murphy wrote:
> On Mon, Feb 16, 2009 at 11:57 PM, Mike Murphy <mamurph@cs.clemson.edu> wrote:
> > Unless that is some common error that is obvious from its description,
> > I will have to chase the bug down tomorrow or Wednesday. It's getting
> > a bit late here.
> >
>
> Fixed... the function signature was wrong. Should have been:
Ah, always pay attention to complier warnings :)
> static ssize_t xpad_show_dead_zone(struct device *dev, struct
> device_attribute *attr, char *buf)
>
> Incidentally, both Documentation/driver-model/device.txt and
> Documentation/filesystems/sysfs.txt appear to be wrong. The former
> defines the device attribute structure as:
<snip>
Care to send a patch to fix up the documentation?
thanks,
greg k-h
prev parent reply other threads:[~2009-02-17 18:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 4:08 [PATCH] input: xpad.c - Xbox 360 wireless and sysfs support Mike Murphy
2009-02-16 8:31 ` Oliver Neukum
2009-02-16 13:22 ` Mike Murphy
2009-02-16 15:21 ` Oliver Neukum
2009-02-19 4:04 ` Mike Murphy
2009-02-16 16:13 ` Greg KH
2009-02-16 18:09 ` Mike Murphy
2009-02-16 18:59 ` Greg KH
2009-02-16 19:30 ` Mike Murphy
2009-02-16 20:22 ` Greg KH
2009-02-17 2:53 ` Mike Murphy
2009-02-17 3:18 ` Greg KH
2009-02-17 4:57 ` Mike Murphy
2009-02-17 18:27 ` Mike Murphy
2009-02-17 18:39 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217183954.GA22850@kroah.com \
--to=greg@kroah.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mamurph@cs.clemson.edu \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox