public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "J.A. Magallón" <jamagallon@ono.com>
To: Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Bonding-devel] 2.6.29 regression? Bonding tied to IPV6 in 29-rc5
Date: Tue, 17 Feb 2009 23:18:16 +0100	[thread overview]
Message-ID: <20090217231816.71c9ebaa@werewolf.home> (raw)
In-Reply-To: <499B30DC.5040303@hp.com>

On Tue, 17 Feb 2009 16:49:16 -0500, Brian Haley <brian.haley@hp.com> wrote:

> Jay Vosburgh wrote:
> > Brian Haley <brian.haley@hp.com> wrote:
> > 
> >> Andrey Borzenkov wrote:
> > [...]
> >>> This hard dependency was apparently introduced by this commit:
> >>>
> >>> commit 305d552accae6afb859c493ebc7d98ca3371dae2
> >>> Author: Brian Haley <brian.haley@hp.com>
> >>> Date:   Tue Nov 4 17:51:14 2008 -0800
> >>>
> >>>     bonding: send IPv6 neighbor advertisement on failover
> >> I initially had bonding IPv6 support as a Kconfig option, but it was 
> >> decided it would be cleaner if it just got built-in whenever CONFIG_IPV6 
> >> was set like SCTP, with the assumption you might want it.
> >>
> >> Is it a common configuration to not allow a module to load like you're 
> >> doing in modprobe.conf?  I don't know how hard it would be to rip this 
> >> out into it's own bonding_ipv6.ko module, simply turning-off CONFIG_IPV6 
> >> seems better.
> > 
> > 	I'm not sure either of those really helps.  Distro kernels are
> > built with CONFIG_IPV6 (and would have the CONFIG_BONDING_IPV6_DINGUS
> > enabled as well), so the common case users would have it enabled, too.
> 
> I think that was one of the reasons too.
> 
> > 	Putting the ipv6 bits into a different module might not help,
> > either, because the "core" bonding code would still have the call to the
> > ipv6 functions.  Unless there's some magic way to somehow know at
> > runtime whether or not the ipv6 module is loaded, and only try to
> > resolve those symbols if ipv6 is loaded.  That seems complicated.
> 
> This separate bonding_ipv6 module would have to register itself with the 
> "core" one with a new proto_ops of some sort.  Calls are made for the 
> appropriate method, for example bond_ops->send_gratuitous(bond).  We'd 
> change the IPv4 code too.  It's just a theory, does make things more 
> complicated.
> 
> > 	To answer your question, I have come across this (aliasing ipv6
> > to nothing in modprobe.conf to disable IPv6) from time to time, but
> > didn't think of it when the NA code was added to bonding.
> 
> So I guess I'll start hacking the above, unless someone has a better 
> suggestion.

Perhaps the right way to start would be to think is if blocking the load
of ipv6 is the right way to disable IPV6.

Just as an example I realized recently (and I know it's not the same) if
I don't have ext4 loaded I can't format a disk on ext4. But disks still
work...

IPV6 looks like a special part of the kernel to disable _at runtime_.

-- 
J.A. Magallon <jamagallon()ono!com>     \               Software is like sex:
                                         \         It's better when it's free
Mandriva Linux release 2009.1 (Cooker) for x86_64
Linux 2.6.28.2-desktop-1mnb (gcc 4.3.2 (GCC) #1 Wed Jan

  reply	other threads:[~2009-02-17 22:18 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-13 22:20 Linux v2.6.29-rc5 Linus Torvalds
2009-02-17  8:52 ` Bonding tied to IPV6 in 29-rc5 J.A. Magallón
2009-02-17 17:01   ` 2.6.29 regression? " Andrey Borzenkov
2009-02-17 18:17     ` Andrey Borzenkov
2009-02-17 20:08       ` [Bonding-devel] " Jay Vosburgh
2009-02-17 22:49         ` David Miller
2009-02-17 20:10       ` Brian Haley
2009-02-17 20:56         ` Thomas Backlund
2009-02-17 21:06         ` [Bonding-devel] " Jay Vosburgh
2009-02-17 21:49           ` Brian Haley
2009-02-17 22:18             ` J.A. Magallón [this message]
2009-02-17 22:24             ` Jay Vosburgh
2009-03-04 11:46               ` Jan Engelhardt
2009-02-17 22:30           ` Nicolas de Pesloüan
2009-02-17 22:54           ` David Miller
2009-02-17 22:51         ` David Miller
2009-02-17 22:29     ` David Miller
2009-02-18  4:41       ` Valdis.Kletnieks
2009-02-18  5:29         ` David Miller
2009-02-18  5:55           ` Roland Dreier
2009-02-18 13:55           ` Theodore Tso
2009-02-18 16:24             ` Chuck Lever
2009-02-18 18:33               ` Vlad Yasevich
2009-02-18 19:57                 ` Brian Haley
2009-02-18 21:21                   ` John Dykstra
2009-02-18 21:29                     ` [Bonding-devel] " Stephen Hemminger
2009-02-19 13:32                   ` Herbert Xu
2009-02-18 22:14                 ` David Miller
2009-02-19  1:11                   ` Vlad Yasevich
2009-02-19 13:29             ` Herbert Xu
2009-02-18  6:55         ` Frank Blaschka
2009-02-19 18:15     ` Randy Dunlap
2009-02-19 18:19       ` Andrey Borzenkov
2009-02-19 18:20       ` Jay Vosburgh
2009-03-04  6:05   ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090217231816.71c9ebaa@werewolf.home \
    --to=jamagallon@ono.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox