From: David Miller <davem@davemloft.net>
To: baranov@mercdev.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] niu: improve ethtool support for gigabit copper cards
Date: Wed, 18 Feb 2009 17:53:41 -0800 (PST) [thread overview]
Message-ID: <20090218.175341.142384927.davem@davemloft.net> (raw)
In-Reply-To: <20090217103852.48b110af.baranov@mercdev.com>
From: Constantin Baranov <baranov@mercdev.com>
Date: Tue, 17 Feb 2009 10:38:52 +0400
> Introduced support for link speed and duplex setting (ethtool -s),
> link advertising parameters and autonegotiation (ethtool -r):
> - struct niu_link_config: split advertising and autoneg
> fields into active and target values (similar to speed
> and duplex fields)
> - mii_init_common(): rewrite function to actually apply
> requested niu_link_config parameters instead of providing
> default initialization
> - link_status_1g(): move parsing of MII registers into
> new link_status_mii() function (link_status_1g_rgmii()
> could possibly use this new implementation too)
> - introduce simple nway_reset method
> - fix incorrect XMAC_CONFIG_MODE selection for 10Mbps case
>
> Signed-off-by: Constantin Baranov <baranov@mercdev.com>
Looks good, patch applied, thanks.
next parent reply other threads:[~2009-02-19 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090217103852.48b110af.baranov@mercdev.com>
2009-02-19 1:53 ` David Miller [this message]
2009-02-17 11:43 [PATCH 2/2] niu: improve ethtool support for gigabit copper cards Constantin Baranov
2009-02-17 13:53 ` Ben Hutchings
2009-02-17 14:43 ` Constantin Baranov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218.175341.142384927.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=baranov@mercdev.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox