From: Olof Johansson <olof@lixom.net>
To: dayu@datangmobile.cn
Cc: leoli@freescale.com, galak@kernel.crashing.org,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.25-2.6.28)
Date: Tue, 17 Feb 2009 20:43:12 -0600 [thread overview]
Message-ID: <20090218024312.GA14848@lixom.net> (raw)
In-Reply-To: <D728AD1FA2543948B89DE29C5BF4CD0716AC37FD@bjmail1.bj.datangmobile.com>
On Wed, Feb 18, 2009 at 10:16:07AM +0800, dayu@datangmobile.cn wrote:
> From: Da Yu <dayu@datangmobile.cn>
> Date: Wed, 18 Feb 2009 19:58:20 +0800
> Subject: [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.25-2.6.28)
>
> Signed-off-by: Da Yu <dayu@datangmobile.cn>
Still no proper explanation in the patch.
Also, with this change, is 'temp' really needed, or can you just pass in the
mask by hand?
-Olof
> ---
>
> --- a/arch/powerpc/sysdev/ipic.c 2009-02-18 09:47:04.000000000 +0800
> +++ b/arch/powerpc/sysdev/ipic.c 2009-02-18 09:46:34.000000000 +0800
> @@ -568,8 +568,7 @@ static void ipic_ack_irq(unsigned int vi
>
> spin_lock_irqsave(&ipic_lock, flags);
>
> - temp = ipic_read(ipic->regs, ipic_info[src].ack);
> - temp |= (1 << (31 - ipic_info[src].bit));
> + temp = 1 << (31 - ipic_info[src].bit);
> ipic_write(ipic->regs, ipic_info[src].ack, temp);
>
> /* mb() can't guarantee that ack is finished. But it does finish
next prev parent reply other threads:[~2009-02-18 2:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-18 2:16 [PATCH] fix the interrupt loss problem on powerpc IPIC (2.6.25-2.6.28) dayu
2009-02-18 2:43 ` Olof Johansson [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-18 5:47 [PATCH] fix the interrupt loss problem on powerpc IPIC(2.6.25-2.6.28) dayu
2009-02-19 16:41 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218024312.GA14848@lixom.net \
--to=olof@lixom.net \
--cc=dayu@datangmobile.cn \
--cc=galak@kernel.crashing.org \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox