From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754423AbZBRIGL (ORCPT ); Wed, 18 Feb 2009 03:06:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753263AbZBRIFw (ORCPT ); Wed, 18 Feb 2009 03:05:52 -0500 Received: from byss.tchmachines.com ([208.76.80.75]:49950 "EHLO byss.tchmachines.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753232AbZBRIFu (ORCPT ); Wed, 18 Feb 2009 03:05:50 -0500 Date: Wed, 18 Feb 2009 00:05:46 -0800 From: Josh Hunt To: Sam Ravnborg Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, kiran@scalex86.org, mingo@elte.hu Subject: Re: [PATCH] Add vmlinux to kernel rpm - updated description Message-ID: <20090218080546.GA8115@localhost.localdomain> References: <20090212051057.GC12732@localhost.localdomain> <20090215080136.GA26481@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090215080136.GA26481@uranus.ravnborg.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - byss.tchmachines.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - scalex86.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 15, 2009 at 09:01:36AM +0100, Sam Ravnborg wrote: > On Wed, Feb 11, 2009 at 09:10:57PM -0800, Josh Hunt wrote: > > Resending with updated description: > > > > We are building an automated system to test kernels weekly and need to > > provide an rpm to our QA dept. We would like to use the ability to create > > kernel rpms already in the kernel's Makefile, but need the vmlinux file > > included in the rpm for later debugging. This patch adds a compressed vmlinux to > > the kernel rpm when doing a make rpm-pkg or binrpm-pkg and upon install > > places the vmlinux file in /boot. > > > > Signed-off-by: Josh Hunt > > Applied, but... > > > > > Index: linux-2.6.28/scripts/package/mkspec > > =================================================================== > > --- linux-2.6.28.orig/scripts/package/mkspec 2008-12-24 > > 15:26:37.000000000 -0800 > > +++ linux-2.6.28/scripts/package/mkspec 2009-01-21 > > 16:53:03.000000000 -0800 > > @@ -86,6 +86,14 @@ echo "%endif" > > echo 'cp System.map $RPM_BUILD_ROOT'"/boot/System.map-$KERNELRELEASE" > > > > echo 'cp .config $RPM_BUILD_ROOT'"/boot/config-$KERNELRELEASE" > > + > > +echo "%ifnarch ppc64" > > +echo 'cp vmlinux vmlinux.orig' > why is this relevant for all architectures except ppc64? > This is not addressed neither in a comment nor in the changelog. I was under the impression that the ppc64 vmlinuz file could be unzipped and used for debugging and so adding it to /boot would be redundant. Please let me know if this is not the case and I will submit an updated patch. Thanks Josh