From: Andrew Morton <akpm@linux-foundation.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Edward Shishkin <edward.shishkin@gmail.com>,
peterz@infradead.org, rmh3093@gmail.com, randy.dunlap@oracle.com,
linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org
Subject: Re: [patch 1/2] vfs: add/use update_page_accounting
Date: Wed, 18 Feb 2009 10:23:14 -0800 [thread overview]
Message-ID: <20090218102314.15a0b0c6.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090218140626.GA13362@wotan.suse.de>
On Wed, 18 Feb 2009 15:06:26 +0100 Nick Piggin <npiggin@suse.de> wrote:
> On Wed, Feb 18, 2009 at 04:27:02PM +0300, Edward Shishkin wrote:
> > > > Maybe it makes sense to add comments with warnings
> > > > in all such places, or create a header file with a static inline
> > > > function update_page_accounting() ?
> > >
> > > Could just uninline the helper function I guess - if you look, those
> > > four statements already involve doing a heck of a lot of stuff.
> > >
> > > Try it, see how it looks?
> > >
> >
> > Done.
> > Please, review.
> >
> > Add/use a helper function update_page_accounting().
>
> Fine patch, except the name I don't like. account_set_page_dirty, or
> account_page_dirtied, or something to hint it is for accounting
> dirty.
yep, sorry, I didn't think too hard about that for-example.
I'll edit the diffs..
next prev parent reply other threads:[~2009-02-18 18:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 11:56 [patch 2/4] vfs: add set_page_dirty_notag Edward Shishkin
2009-02-13 13:08 ` Peter Zijlstra
2009-02-13 13:57 ` Edward Shishkin
2009-02-13 14:09 ` Peter Zijlstra
2009-02-14 13:11 ` Edward Shishkin
2009-02-14 21:11 ` Peter Zijlstra
2009-02-16 22:43 ` Edward Shishkin
2009-02-17 9:09 ` Peter Zijlstra
2009-02-17 9:38 ` Nick Piggin
2009-02-17 10:05 ` Peter Zijlstra
2009-02-17 10:24 ` Nick Piggin
2009-02-17 10:40 ` set_page_dirty races (was: Re: [patch 2/4] vfs: add set_page_dirty_notag) Peter Zijlstra
2009-02-17 11:25 ` Nick Piggin
2009-02-17 11:39 ` Peter Zijlstra
2009-02-17 11:55 ` Nick Piggin
2009-02-17 12:05 ` Peter Zijlstra
2009-02-17 12:30 ` Nick Piggin
2009-02-17 22:35 ` [patch 2/4] vfs: add set_page_dirty_notag Andrew Morton
2009-02-18 0:26 ` Edward Shishkin
2009-02-18 0:38 ` Andrew Morton
2009-02-18 13:27 ` [patch 1/2] vfs: add/use update_page_accounting Edward Shishkin
2009-02-18 14:06 ` Nick Piggin
2009-02-18 18:23 ` Andrew Morton [this message]
2009-02-18 13:27 ` [patch 2/2] vfs: (take 2)add set_page_dirty_notag Edward Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090218102314.15a0b0c6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=edward.shishkin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=peterz@infradead.org \
--cc=randy.dunlap@oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=rmh3093@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox