public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Petr Tesarik <ptesarik@suse.cz>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Definition of BUG on x86
Date: Thu, 19 Feb 2009 13:22:11 +0100	[thread overview]
Message-ID: <20090219122211.GE1703@elte.hu> (raw)
In-Reply-To: <1235045971.15053.42.camel@nathan.suse.cz>


* Petr Tesarik <ptesarik@suse.cz> wrote:

> Ingo Molnar píše v Čt 19. 02. 2009 v 13:10 +0100:
> > * Petr Tesarik <ptesarik@suse.cz> wrote:
> > 
> > > So, the only method I could invent was using gas macros. It 
> > > works but is quite ugly, because it relies on the actual 
> > > assembler instruction which is generated by the compiler. Now, 
> > > AFAIK gcc has always translated "for(;;)" into a jump to self, 
> > > and that with any conceivable compiler options, but I don't 
> > > know anything about Intel cc.
> > 
> > > +static inline __noreturn void discarded_jmp(void)
> > > +{
> > > +	asm volatile(".macro jmp target\n"
> > > +		     "\t.purgem jmp\n"
> > > +		     ".endm\n");
> > > +	for (;;) ;
> > > +}
> > 
> > hm, that's very fragile.
> > 
> > Why not just:
> > 
> >  static inline __noreturn void x86_u2d(void)
> >  {
> > 	asm volatile("u2d\n");
> >  }
> > 
> > If GCC emits a bogus warning about _that_, then it's a bug in 
> > the compiler that should be fixed.
> 
> I wouldn't call it a bug. The compiler has no idea about what 
> the inline assembly actualy does. So it cannot recognize that 
> the ud2 instruction does not return (which BTW might not even 
> be the case, depending on the implementation of the Invalid 
> Opcode exception).

No, i'm not talking about the inline assembly.

I'm talking about the x86_u2d() _inline function_, which has 
the __noreturn attribute.

Shouldnt that be enough to tell the compiler that it ... wont 
return?

	Ingo

  reply	other threads:[~2009-02-19 12:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1234975856.15053.16.camel@nathan.suse.cz>
     [not found] ` <499C4786.5010504@goop.org>
2009-02-19 11:40   ` Definition of BUG on x86 Petr Tesarik
2009-02-19 12:10     ` Ingo Molnar
2009-02-19 12:19       ` Petr Tesarik
2009-02-19 12:22         ` Ingo Molnar [this message]
2009-02-19 12:38           ` Petr Tesarik
2009-02-19 12:47             ` Ingo Molnar
2009-02-19 13:02               ` Petr Tesarik
2009-02-19 14:49                 ` Ingo Molnar
2009-02-19 15:32                   ` Jeremy Fitzhardinge
2009-02-19 15:35                     ` Ingo Molnar
2009-02-19 16:11                       ` Petr Tesarik
2009-02-19 16:16                         ` Ingo Molnar
2009-02-19 16:34                           ` Jeremy Fitzhardinge
2009-02-19 16:41                             ` Ingo Molnar
2009-02-19 20:07                             ` H. Peter Anvin
2009-02-19 20:26                               ` Ingo Molnar
2009-02-19 16:55                           ` Petr Tesarik
2009-02-19 16:32                       ` Jeremy Fitzhardinge
2009-02-19 18:38     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090219122211.GE1703@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ptesarik@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox