From: Tim Blechmann <tim@klingt.org>
To: oprofile-list@lists.sf.net, linux-kernel@vger.kernel.org
Cc: Robert Richter <robert.richter@amd.com>,
Andi Kleen <andi@firstfloor.org>
Subject: [PATCH] oprofile: don't set counter width from cpuid on core2
Date: Thu, 19 Feb 2009 17:34:03 +0100 [thread overview]
Message-ID: <20090219173403.49871cac@thinkpad> (raw)
In-Reply-To: <20090216114010.GG25042@erda.amd.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=US-ASCII, Size: 1585 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
resetting the counter width of the performance counters on intel's
core2, breaks the delivery of NMIs, when running in x86_64 mode.
this should fix bug #12395:
http://bugzilla.kernel.org/show_bug.cgi?id=12395
Signed-off-by: Tim Blechmann <tim@klingt.org>
- ---
arch/x86/oprofile/op_model_ppro.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/x86/oprofile/op_model_ppro.c b/arch/x86/oprofile/op_model_ppro.c
index e9f80c7..ecba9f2 100644
- --- a/arch/x86/oprofile/op_model_ppro.c
+++ b/arch/x86/oprofile/op_model_ppro.c
@@ -78,10 +78,18 @@ static void ppro_setup_ctrs(struct op_msrs const * const msrs)
if (cpu_has_arch_perfmon) {
union cpuid10_eax eax;
eax.full = cpuid_eax(0xa);
+
+ /* For core2 (family 6, model 15), don't reset the counter width */
+ if (eax.split.version_id == 0 && current_cpu_data.x86 == 6 &&
+ current_cpu_data.x86_model == 15)
+ goto clear_all_counters;
+
if (counter_width < eax.split.bit_width)
counter_width = eax.split.bit_width;
}
+clear_all_counters:
+
/* clear all counters */
for (i = 0 ; i < num_counters; ++i) {
if (unlikely(!CTRL_IS_RESERVED(msrs, i)))
- --
1.6.1.2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkmdifsACgkQdL+4qsZfVsu7uwCffznCNF7PKtaRw0Z28qy6PtO1
DP8AnjkSBNLvKGdG8ac90ayoO2L7GRjW
=xYgd
-----END PGP SIGNATURE-----
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2009-02-19 16:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 14:23 2.6.28-rc9: oprofile regression Tim Blechmann
2008-12-21 21:23 ` Tim Blechmann
2008-12-22 12:11 ` Robert Richter
2008-12-26 2:42 ` Andi Kleen
2009-01-02 11:04 ` Tim Blechmann
2009-01-14 17:10 ` Thomas Gleixner
2009-01-14 18:19 ` Tim Blechmann
2009-01-15 8:46 ` Thomas Gleixner
2009-01-15 9:14 ` Tim Blechmann
2009-01-15 20:37 ` Thomas Gleixner
2009-01-16 0:53 ` Tim Blechmann
2009-01-16 8:59 ` Thomas Gleixner
2009-01-16 11:29 ` Tim Blechmann
2009-01-16 15:52 ` Thomas Gleixner
2009-01-16 16:02 ` Tim Blechmann
2009-01-17 13:32 ` Tim Blechmann
2009-01-17 14:14 ` Robert Richter
2009-01-17 15:09 ` Tim Blechmann
2009-01-17 15:56 ` Robert Richter
2009-01-17 16:40 ` Tim Blechmann
2009-02-11 19:51 ` 2.6.29-rc4 regression (was: Re: 2.6.28-rc9: oprofile regression) Tim Blechmann
2009-02-13 19:07 ` Robert Richter
2009-02-16 10:23 ` Tim Blechmann
2009-02-16 11:33 ` Robert Richter
2009-02-16 12:53 ` 2.6.29-rc4 regression Tim Blechmann
2009-02-17 7:45 ` Mike Galbraith
2009-02-17 21:56 ` Tim Blechmann
2009-02-18 4:54 ` Mike Galbraith
2009-02-16 11:40 ` 2.6.29-rc4 regression (was: Re: 2.6.28-rc9: oprofile regression) Robert Richter
2009-02-19 16:34 ` Tim Blechmann [this message]
2009-03-03 10:04 ` [PATCH] oprofile: don't set counter width from cpuid on core2 Robert Richter
2009-03-03 11:05 ` Ingo Molnar
2009-03-03 11:09 ` [tip:x86/urgent] x86: oprofile: don't set counter width from cpuid on Core2 Tim Blechmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219173403.49871cac@thinkpad \
--to=tim@klingt.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sf.net \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox