From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755437AbZBSUXj (ORCPT ); Thu, 19 Feb 2009 15:23:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753374AbZBSUX2 (ORCPT ); Thu, 19 Feb 2009 15:23:28 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:56738 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbZBSUX2 (ORCPT ); Thu, 19 Feb 2009 15:23:28 -0500 Date: Thu, 19 Feb 2009 21:23:17 +0100 From: Ingo Molnar To: Alan Stern Cc: linux-scsi@vger.kernel.org, James Bottomley , Jens Axboe , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Subject: Re: scsi: aic7xxx hang since v2.6.28-rc1 ... Message-ID: <20090219202317.GA784@elte.hu> References: <20090218155817.GC23989@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Alan Stern wrote: > On Wed, 18 Feb 2009, Ingo Molnar wrote: > > > > > * Alan Stern wrote: > > > > > I have no idea if this will make any difference for the > > > problem you're seeing, but it has been submitted and it's > > > worth trying out. If the problem still occurs, I'll write a > > > diagnostic patch to add log messages giving the destiny of > > > each request in scsi_io_completion(). > > > > OK, i've undone the reverts and have applied your fix - it will > > take a few hours to see whether the hang still occurs. > > Any definitive results yet? Yes, as i wrote before, the bug is fixed. > It turns out that the patch I posted earlier is not quite > correct; the "__scsi_release_buffers(cmd, 0);" line in > scsi_end_request() was added after the patch was first written > and then got lost during rebasing. Yeah, rebasing is a really bad idea in general. > If this really does fix your problem and nobody has any other > objections to it, I'll submit a revised version with the > missing line added back in. Sure, no objections. Ingo