Re: [s390] next Feb 18: defconfig build break

Mike Frysinger
2009-02-19T01:55:27Z

On Wed, Feb 18, 2009 at 17:59, Rusty Russell wrote:
> On Thursday 19 February 2009 03:40:59 Mike Frysinger wrote:
>> breaks all Blackfin ports as well:
>> In file included from include/linux/bitmap.h:9,
>> from include/linux/nodemask.h:90,
>> from include/linux/mmzone.h:17,
>> from include/linux/gfp.h:5,
>> from include/linux/kmod.h:23,
>> from include/linux/module.h:14,
>> from arch/blackfin/lib/strncmp.c:14:
>> include/linux/string.h: In function 'strstarts':
>> include/linux/string.h:124: error: implicit declaration of function 'strncmp'
>> make[1]: *** [arch/blackfin/lib/strncmp.o] Error 1
>> make: *** [arch/blackfin/lib] Error 2
>
> I don't have a blackfin cross compiler, but I think this is the right
> fix:

np ... fix is almost correct :)

> --- a/arch/blackfin/lib/strncmp.c
> +++ b/arch/blackfin/lib/strncmp.c
> @@ -6,6 +6,7 @@
> * Licensed under the GPL-2 or later.
> */
>
> +int strncmp(const char *cs, const char *ct, size_t count);
> #define strncmp __inline_strncmp
> #include <asm/string.h>
> #undef strncmp
> diff --git a/arch/blackfin/lib/strncpy.c b/arch/blackfin/lib/strncpy.c
> --- a/arch/blackfin/lib/strncpy.c
> +++ b/arch/blackfin/lib/strncpy.c
> @@ -6,6 +6,7 @@
> * Licensed under the GPL-2 or later.
> */
>
> +char *strncpy(char *dest, const char *src, size_t n);
> #define strncpy __inline_strncpy
> #include <asm/string.h>
> #undef strncpy

size_t is not a builtin type so there needs to be a linux/types.h
include right above these two prototypes. then things build up fine
for me.

thanks!
-mike