Re: [s390] next Feb 18: defconfig build break

Russell King
2009-02-19T09:52:49Z

On Thu, Feb 19, 2009 at 10:45:25AM +1030, Rusty Russell wrote:
> Subject: arm: allow usage of string functions in linux/string.h
>
> In introducing a trivial "strstarts()" function in linux/string.h, we
> hit:
>
> arch/arm/boot/compressed/misc.o: In function `strstarts':
> misc.c:(.text+0x368): undefined reference to `strlen'
> misc.c:(.text+0x378): undefined reference to `strncmp'
>
> This is because of "CFLAGS_misc.o := -Dstatic=" in the Makefile.
> "static inline strstarts(...)" becomes non-inline, and refers to the
> other string ops.
>
> The simplest workaround is to include asm/string.h. This makes sense
> anyway, since lib/string.c won't be linked against this so we can't
> use those functions anyway.
>
> Compile tested here.
>
> Reported-by: linux-next
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

I guess this should go in with the change which caused the breakage.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/