Re: [PATCH] module: fix build for CONFIG_SYSFS=n

Ingo Molnar
2009-02-18T18:10:00Z

* Randy Dunlap <randy.dunlap@oracle.com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix this build error when CONFIG_SYSFS=n:
>
> kernel/built-in.o: In function `free_module':
> module.c:(.text+0x4f8a2): undefined reference to `destroy_params'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Rusty Russell <rusty@rustcorp.com.au>
> ---
> kernel/module.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20090218.orig/kernel/module.c
> +++ linux-next-20090218/kernel/module.c
> @@ -1464,8 +1464,10 @@ static void free_module(struct module *m
> /* Module unload stuff */
> module_unload_free(mod);
>
> +#ifdef CONFIG_SYSFS
> /* Free any allocated parameters. */
> destroy_params(mod->kp, mod->num_kp);
> +#endif

Is destroy_params() dependent on SYSFS? If yes then it would be
far cleaner if there was a NOP destroy_params() inline for the
!SYSFS case.

Ingo