public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Hunt <josh@scalex86.org>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, kiran@scalex86.org
Subject: Clocksource with rating 0 marked unstable twice
Date: Thu, 19 Feb 2009 20:57:49 -0800	[thread overview]
Message-ID: <20090220045749.GC8151@localhost.localdomain> (raw)

I have a system with TSCs which are known to be unsynchronized.
During TSC initialization it is marked as unstable, but later on in
the boot the clocksource watchdog code also marks it unstable.  This
seems a bit redundant as both set the rating to 0.

<dmesg snippet>
[    0.000000] Marking TSC unstable due to TSCs unsynchronized
...
[    4.740022] Clocksource tsc unstable (delta = 4380394573887 ns)
</dmesg snippet>

I can think of two solutions, both modifying clocksource_register
when rating is 0:

1. Do not call clocksource_check_watchdog. This way the clocksource
is not put on the watchdog list.

2. Do not enqueue the clocksource or do any registering.  Is there a
good reason to keep around a clocksource which has a rating of 0?

Which of these would be better?  I can provide a patch for either.

Thanks
Josh

                 reply	other threads:[~2009-02-20  4:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090220045749.GC8151@localhost.localdomain \
    --to=josh@scalex86.org \
    --cc=kiran@scalex86.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox