public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andres Salomon <dilinger@queued.net>
To: drzeus-sdhci@drzeus.cx
Cc: sdhci-devel@list.drzeus.cx, linux-kernel@vger.kernel.org, cjb@laptop.org
Subject: OLPC XO-1 sdhci regression
Date: Fri, 20 Feb 2009 12:43:43 -0500	[thread overview]
Message-ID: <20090220124343.707b83b4@ephemeral> (raw)

Hi Pierre,

With the current Linus git tree, the sdhci driver fails to find the partition
table on cards during bootup on OLPC XO-1 machines.  This makes booting off of
SD impossible.  The errors go something like this:

 mmcblk0:
mmc0: Timeout waiting for hardware interrupt.
mmcblk0: error -110 sending stop command
end_request: I/O error, dev mmcblk0, sector 0
Buffer I/O error on device mmcblk0, logical block 0
[repeat a bunch of times]
  unable to read partition table

No oopses or anything, the SD controller just fails to read the partition
table off the card.

I bisected a bit, and that led me to this commit:

 commit e809517f6fa5803a5a1cd56026f0e2190fc13d5c
 Author: Pierre Ossman <drzeus@drzeus.cx>
 Date:   Fri Jul 25 01:09:08 2008 +0200

     sdhci: let the controller wait for busy state to end
    
     The sdhci controllers can interrupt us when the busy state from the
     card has ended, saving CPU cycles and power.
    
     Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>

Reverting that commit allows the driver to read the partition table.

             reply	other threads:[~2009-02-20 17:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20 17:43 Andres Salomon [this message]
2009-02-21  3:03 ` OLPC XO-1 sdhci regression Andres Salomon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090220124343.707b83b4@ephemeral \
    --to=dilinger@queued.net \
    --cc=cjb@laptop.org \
    --cc=drzeus-sdhci@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sdhci-devel@list.drzeus.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox