OLPC XO-1 sdhci regression

OLPC XO-1 sdhci regression

[Andres Salomon]

Hi Pierre,

With the current Linus git tree, the sdhci driver fails to find the partition
table on cards during bootup on OLPC XO-1 machines.  This makes booting off of
SD impossible.  The errors go something like this:

 mmcblk0:
mmc0: Timeout waiting for hardware interrupt.
mmcblk0: error -110 sending stop command
end_request: I/O error, dev mmcblk0, sector 0
Buffer I/O error on device mmcblk0, logical block 0
[repeat a bunch of times]
  unable to read partition table

No oopses or anything, the SD controller just fails to read the partition
table off the card.

I bisected a bit, and that led me to this commit:

 commit e809517f6fa5803a5a1cd56026f0e2190fc13d5c
 Author: Pierre Ossman <drzeus@drzeus.cx>
 Date:   Fri Jul 25 01:09:08 2008 +0200

     sdhci: let the controller wait for busy state to end
    
     The sdhci controllers can interrupt us when the busy state from the
     card has ended, saving CPU cycles and power.
    
     Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>

Reverting that commit allows the driver to read the partition table.

Re: OLPC XO-1 sdhci regression

[Andres Salomon]

On Fri, 20 Feb 2009 12:43:43 -0500
Andres Salomon <dilinger@queued.net> wrote:

> Hi Pierre,
> 
> With the current Linus git tree, the sdhci driver fails to find the
> partition table on cards during bootup on OLPC XO-1 machines.  This
> makes booting off of SD impossible.  The errors go something like
> this:
> 
[...]


A quirk proposed by Anton fixes the issue.  The attached patch adds the
quirk for the Marvell CAFE controller.



Subject: [PATCH] SDHCI: Add NO_BUSY_IRQ quirk for Marvell CAFE host chip

As described here: http://lkml.org/lkml/2009/2/20/265

The CAFE chip is broken due to commit e809517f6fa5803a5a1cd56026f0e2190fc13d5c.
Anton added a quirk here: http://lkml.org/lkml/2009/2/20/279 that fixes
CAFE's problem.  This adds the quirk for CAFE.

Obviously, this depends upon Anton's patch.

Signed-off-by: Andres Salomon <dilinger@debian.org>
---
 drivers/mmc/host/sdhci-pci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index 8cff5f5..406da9a 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -107,6 +107,7 @@ static const struct sdhci_pci_fixes sdhci_ene_714 = {
 
 static const struct sdhci_pci_fixes sdhci_cafe = {
 	.quirks		= SDHCI_QUIRK_NO_SIMULT_VDD_AND_POWER |
+			  SDHCI_QUIRK_NO_BUSY_IRQ |
 			  SDHCI_QUIRK_BROKEN_TIMEOUT_VAL,
 };
 
-- 
1.5.6.5