From: Andrew Morton <akpm@linux-foundation.org>
To: Andrew Patterson <andrew.patterson@hp.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
andrew.patterson@hp.com
Subject: Re: [PATCH] PCI: Enable PCIe AER only after checking firmware support
Date: Fri, 20 Feb 2009 13:52:53 -0800 [thread overview]
Message-ID: <20090220135253.ab057442.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090219171107.26521.7298.stgit@bob.kio>
On Thu, 19 Feb 2009 10:11:07 -0700
Andrew Patterson <andrew.patterson@hp.com> wrote:
> PCI: Enable PCIe AER only after checking firmware support
>
> The PCIe port driver currently sets the PCIe AER error reporting bits for
> any root or switch port without first checking to see if firmware will grant
> control. This patch moves setting these bits to the AER service driver
> aer_enable_port routine. The bits are then set for the root port and any
> downstream switch ports after the check for firmware support (aer_osc_setup)
> is made. The patch also unsets the bits in a similar fashion when the AER
> service driver is unloaded.
>
> ...
>
> +/**
> + * set_downstream_devices_error_reporting - enable/disable the error reporting
> + * bits on the root port and its downstream ports.
Alas, silly kerneldoc does not permit multi-line titles. We're forced
to do this:
--- a/drivers/pci/pcie/aer/aerdrv_core.c~pci-enable-pcie-aer-only-after-checking-firmware-support-fix
+++ a/drivers/pci/pcie/aer/aerdrv_core.c
@@ -125,8 +125,7 @@ static void set_device_error_reporting(s
}
/**
- * set_downstream_devices_error_reporting - enable/disable the error reporting
- * bits on the root port and its downstream ports.
+ * set_downstream_devices_error_reporting - enable/disable the error reporting bits on the root port and its downstream ports.
* @dev: pointer to root port's pci_dev data structure
* @enable: true = enable error reporting, false = disable error reporting.
*/
_
prev parent reply other threads:[~2009-02-20 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 17:11 [PATCH] PCI: Enable PCIe AER only after checking firmware support Andrew Patterson
2009-02-20 21:52 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090220135253.ab057442.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andrew.patterson@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox