public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alistair John Strachan <alistair@devzero.co.uk>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: isight_firmware interacts badly with suspend/resume
Date: Sun, 22 Feb 2009 19:45:21 +0000	[thread overview]
Message-ID: <200902221945.21571.alistair@devzero.co.uk> (raw)

Hi,

A 2.6.29-rc5 S3 suspend/resume cycle seems to break on my 2007 Macbook if I 
have isight_firmware loaded and a valid isight firmware in /lib/firmware.

Normally this module loads/unloads fine (though I've never actually used the 
webcam).

The breakage is not obvious. There's no kernel oops, and my console is 
restored, but only Alt-Fx works, no other keys work. I've had this module 
loaded during suspend/resume since it was introduced into mainline, but I've 
only had problems with it in 2.6.29 and possibly 2.6.28 (can check for sure if 
required).

At the moment I'm rmmod'ing the module before echo mem >/sys/power/state and 
then modprobe'ing it after. This fixes the cycle. At a guess this looks like 
some kind of request_firmware() race (that's the last kernel message I get on 
resume before the hang).

Does isight_firmware actually need to do anything on resume? Is the firmware 
lost for sure in S3? Anything else I can do to debug this?

-- 
Cheers,
Alistair.

                 reply	other threads:[~2009-02-22 19:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902221945.21571.alistair@devzero.co.uk \
    --to=alistair@devzero.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox