Re: [PATCH 1/1] edac x38: new MC driver module

Andrew Morton
2008-10-20T23:32:45Z

On Fri, 17 Oct 2008 15:39:45 -0600
dougthompson@xmission.com wrote:

> From: Hitoshi Mitake <mitake@clustcom.com>
>
> I wrote a new module for Intel X38 chipset.
> This chipset is very similar to Intel 3200 chipset,
> but there are some different points,
> so I copyed i3200_edac.c and modified.
>
> This is a Intel's web page describing this chipset.
> http://www.intel.com/Products/Desktop/Chipsets/X38/X38-overview.htm
>
> I've tested this new module with broken memory,
> and it seems working well.
>
> This is a patch, please use.
> Hitoshi
>
> Signed-off-by: Hitoshi Mitake <mitake@clustcom.com>
> Signed-off-by: Doug Thompson <dougthompson@xmission.com>
> ---
>
> Index: linux-2.6.27/drivers/edac/Kconfig
> ===================================================================
> --- linux-2.6.27.orig/drivers/edac/Kconfig
> +++ linux-2.6.27/drivers/edac/Kconfig
> @@ -102,6 +102,13 @@ config EDAC_I3000
> Support for error detection and correction on the Intel
> 3000 and 3010 server chipsets.
>
> +config EDAC_X38
> + tristate "Intel X38"
> + depends on EDAC_MM_EDAC && PCI && X86
> + help
> + Support for error detection and correction on the Intel
> + X38 server chipsets.

Is this truly X86, or will this driver only ever be used on x86_64 kernels?

>
> ...
>
> +static u64 x38_readq(const void __iomem *addr)
> +{
> + return readl(addr) | (((u64)readl(addr + 4)) << 32);
> +}

Because the x86_64 architecture already implements readq(), and it
would be nice to avoid creating a private version.