Re: [PATCH 1/1] edac x38: new MC driver module

Hitoshi Mitake
2008-11-25T15:30:41Z

On Mon, 24 Nov 2008 21:13:58 -0800
"H. Peter Anvin" <hpa@zytor.com> wrote:

> Hitoshi Mitake wrote:
> > I think which need __ is variable type name, not each variable name.
> > Name of each local variables can't effect namespace.
>
> Wrong. It affects the namespace in the sense that it can interfere with
> user-created macros. Again, this is only an issue for user space.

Sorry, I've misunderstood. I didn't think about macros.

>
> > And I found this comment in asm-generic/int-ll64.h,
> > /*
> > * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the
> > * header files exported to user space
> > */
> >
> > According to your advice, I rewrote the patch, how is this?
>
> Are you planning to add writeq() as well?
>

Yes, I want to add writeq().
But there's a problem that
I don't have a plan to use writeq() now, so I can't test writeq() soon.

How is this? I think it isn't bad. I want to hear your opinion.

static inline void writeq(__u64 val, volatile void __iomem *addr)
{
writel((unsigned int)val, addr);
writel((unsigned int)(val >> 32), addr+1);
}