Re: [PATCH 1/1] edac x38: new MC driver module

H. Peter Anvin
2008-11-25T05:17:51Z

Hitoshi Mitake wrote:
> I think which need __ is variable type name, not each variable name.
> Name of each local variables can't effect namespace.

Wrong. It affects the namespace in the sense that it can interfere with
user-created macros. Again, this is only an issue for user space.

> And I found this comment in asm-generic/int-ll64.h,
> /*
> * __xx is ok: it doesn't pollute the POSIX namespace. Use these in the
> * header files exported to user space
> */
>
> According to your advice, I rewrote the patch, how is this?

Are you planning to add writeq() as well?

-hpa