public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Metzger, Markus T" <markus.t.metzger@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] move exit_ptrace() from forget_original_parent() to do_exit()
Date: Mon, 23 Feb 2009 17:59:32 +0100	[thread overview]
Message-ID: <20090223165932.GB16294@redhat.com> (raw)
In-Reply-To: <20090220022832.CA587FC2F7@magilla.sf.frob.com>

On 02/19, Roland McGrath wrote:
>
> > If we ever change exit_ptrace() to do the blocking calls, it makes
> > sense to move it after exit_signals().
>
> I'm not sure I understand this comment.  I guess you just mean that if we
> block, we should be sure to do the exit_signals() pass-the-pending-buck
> work afterwards.

Another reason: it is better to set PF_EXITING asap, before doing something
which can block/etc. PF_EXITING means that complete_signal()->wants_signal()
will not pick us as ->curr_target.

> OK.  But I think we want it after exit_signals anyway so
> that ptrace_traceme() can check PF_EXITING (cf 1/4 review).

Yes, you are right.

> Also, I think this patch should be the very last of the series.

Agreed.

Oleg.


      reply	other threads:[~2009-02-23 17:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 21:12 [PATCH 3/4] move exit_ptrace() from forget_original_parent() to do_exit() Oleg Nesterov
2009-02-20  2:28 ` Roland McGrath
2009-02-23 16:59   ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090223165932.GB16294@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.t.metzger@intel.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox