Re: [PATCH] x86: make text_poke() atomic using fixmap

Masami Hiramatsu
2009-03-06T14:50:17Z

Hi Ingo,

Ingo Molnar wrote:
> * Ingo Molnar <mingo@elte.hu> wrote:
>
>> * Masami Hiramatsu <mhiramat@redhat.com> wrote:
>>
>>> Hi Ingo,
>>>
>>> Here is the patch which uses fixmaps instead of vmap in
>>> text_poke(). This made the code much simpler than I thought
>>> :).
>> Looks good to me at a quick glance albeit Linus had second
>> thoughts about using fixmaps for this in the past. But with
>> delayed-flush for vmaps i think fixmaps are again the simpler
>> and more robust - albeit more limited - choice ...
>>
>> In any case, the x86 tree already unified fixmap.h so could
>> you please resend the whole series as a 0/3, 1/3, 2/3, 3/3
>> thing against tip:master, starting a new thread on lkml? (this
>> thread is already way too deep)
>
> Ping? I think there's agreement and it would be nice to fix this
> in .30. Looks too complex for .29 - maybe backportable to .29.1
> if it stays problem-free in testing.

Sorry for later, I'll post it as soon as possible.

>
> Ingo

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com