From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH] tracing/ftrace: add missing wake-up on some callsites
Date: Mon, 23 Feb 2009 18:37:14 +0100 [thread overview]
Message-ID: <20090223173714.GA601@elte.hu> (raw)
In-Reply-To: <alpine.DEB.2.00.0902231211230.18221@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> > Which would send a delayed work to wake up?
>
> No, I was thinking that trace_delay_wake_up() would be called
> by these dangerous call sites. Then a per_cpu flag could be
> set. We could have a trace point in the scheduler code that is
> outside holding a runqueue lock, and this trace point would
> call a trace function that will clear the per cpu flag, and
> then call trace_wake_up().
No, that's very roundabout and ugly. If we putting a tracepoint
there we might as well put real scheduler code there that looks
for such a flag. But i'm not convinced we need a flag ...
Ingo
next prev parent reply other threads:[~2009-02-23 17:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-22 21:56 [PATCH] tracing/ftrace: add missing wake-up on some callsites Frederic Weisbecker
2009-02-22 22:16 ` Ingo Molnar
2009-02-23 15:37 ` Steven Rostedt
2009-02-23 15:42 ` Steven Rostedt
2009-02-23 16:26 ` Frederic Weisbecker
2009-02-23 16:51 ` Steven Rostedt
2009-02-23 17:05 ` Frederic Weisbecker
2009-02-23 17:13 ` Steven Rostedt
2009-02-23 17:34 ` Frederic Weisbecker
2009-02-23 17:37 ` Ingo Molnar [this message]
2009-02-23 18:03 ` Steven Rostedt
2009-02-23 18:09 ` Ingo Molnar
2009-02-27 17:04 ` Masami Hiramatsu
2009-02-23 16:22 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090223173714.GA601@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox