From: Andrew Morton <akpm@linux-foundation.org>
To: Andres Salomon <dilinger@queued.net>
Cc: linux-kernel@vger.kernel.org, tiwai@suse.de, katzj@redhat.com,
cjb@laptop.org, jayakumar.alsa@gmail.com,
jordan@cosmicpenguin.net, linux-geode@lists.infradead.org,
perex@perex.cz, David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH 1/2] cs553x-gpio: add AMD CS5535/CS5536 GPIO driver support
Date: Tue, 24 Feb 2009 12:06:37 -0800 [thread overview]
Message-ID: <20090224120637.18073f93.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090220221202.667fbb79@ephemeral>
On Fri, 20 Feb 2009 22:12:02 -0500
Andres Salomon <dilinger@queued.net> wrote:
>
> This creates a CS5535/CS5536 GPIO driver which uses a gpio_chip backend
> (allowing GPIO users to use the generic GPIO API if desired) while also
> allowing architecture-specific users directly (via the cs553x_gpio_*
> functions).
>
> Tested on an OLPC machine. Some Leemotes also use CS5536 (with a mips
> cpu), which is why this is in drivers/gpio rather than arch/x86. Currently,
> it conflicts with older geode GPIO support; once MFGPT support is reworked
> to also be more generic, the older geode code will be removed.
>
> +EXPORT_SYMBOL_GPL(cs553x_gpio_set);
> +EXPORT_SYMBOL_GPL(cs553x_gpio_clear);
> +EXPORT_SYMBOL_GPL(cs553x_gpio_isset);
Nothing uses these exports. In fact these symbols could be made static
to drivers/gpio/cs553x-gpio.c?
next prev parent reply other threads:[~2009-02-24 20:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 3:12 [PATCH 1/2] cs553x-gpio: add AMD CS5535/CS5536 GPIO driver support Andres Salomon
2009-02-24 20:06 ` Andrew Morton [this message]
2009-02-24 20:19 ` Andres Salomon
2009-02-25 9:38 ` Alessandro Zummo
2009-02-25 12:04 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090224120637.18073f93.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cjb@laptop.org \
--cc=david-b@pacbell.net \
--cc=dilinger@queued.net \
--cc=jayakumar.alsa@gmail.com \
--cc=jordan@cosmicpenguin.net \
--cc=katzj@redhat.com \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox