From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Kyle McMartin <kyle@infradead.org>
Cc: airlied@redhat.com, linux-kernel@vger.kernel.org,
dri-devel@lists.sourceforge.net, marko.ristola@kolumbus.fi
Subject: Re: [PATCH] drm: edid revision 0 is valid
Date: Tue, 24 Feb 2009 17:44:30 -0800 [thread overview]
Message-ID: <200902241744.30556.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20090225013153.GC6690@bombadil.infradead.org>
On Tuesday, February 24, 2009 5:31:53 pm Kyle McMartin wrote:
> From: Kyle McMartin <kyle@redhat.com>
>
> edid->revision == 0 should be valid (at least, so the error message
> indicates. :) and wikipedia seems to indicate that EDID 1.0 existed.
>
> We can dump the entire check, since edid->revision is a u8, so
> it can't ever be less than 0.
>
> Marko reports in RH bz#476735 that his monitor claims to be
> EDID 1.0, and therefore hits the check and is stuck at 800x600 because
> of it.
>
> Reported-by: Marko Ristola <marko.ristola@kolumbus.fi>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
Heh, yeah this makes the code correct *and* match the message. Thanks.
Acked-by: Jesse Barnes <jbarnes@virtuousgek.org>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2009-02-25 1:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 1:31 [PATCH] drm: edid revision 0 is valid Kyle McMartin
2009-02-25 1:44 ` Jesse Barnes [this message]
2009-03-11 2:56 ` Jamie Lokier
2009-03-11 3:10 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902241744.30556.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marko.ristola@kolumbus.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox