From: Frans Pop <elendil@planet.nl>
To: Dave Jones <davej@redhat.com>
Cc: Mattias-Christian Ott <ott@mirix.org>,
Dominik Brodowski <linux@brodo.de>,
Joerg Platte <jplatte@naasa.net>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
cpufreq@vger.kernel.org
Subject: Re: [PATCH] p4-clockmod: Calculate frequency based on TSC value for P4 models 0 and 1
Date: Tue, 24 Feb 2009 18:13:00 +0100 [thread overview]
Message-ID: <200902241813.02252.elendil@planet.nl> (raw)
In-Reply-To: <20090224165250.GB2998@redhat.com>
On Tuesday 24 February 2009, Dave Jones wrote:
> On Tue, Feb 24, 2009 at 08:08:58AM +0100, Frans Pop wrote:
> > From: Mattias-Christian Ott <ott@mirix.org>
> >
> > Commit ed9cbcd40004904dbe61ccc16d6106a7de38c998 reverted an
> > incorrect change that resulted in random frequencies being displayed
> > in some cases for early P4 models because the MSR_FBC_REGISTER_ID
> > ratio is undefined.
> >
> > Result of the revert is that for some users the CPU frequency is
> > displayed multiplied by a factor 8 in /proc/cpuinfo when p4-clockmod
> > is loaded.
> >
> > Calculating the frequency from the TSC value should work in all
> > cases.
>
> I already picked this up in cpufreq-next.
OK, thanks. The status of the patch was somewhat unclear as, from what I
could see in bugzilla, it had been submitted well before the merge window
for .29 was opened. Good to know it's in the pipeline.
next prev parent reply other threads:[~2009-02-24 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 7:08 [PATCH] p4-clockmod: Calculate frequency based on TSC value for P4 models 0 and 1 Frans Pop
2009-02-24 16:52 ` Dave Jones
2009-02-24 17:13 ` Frans Pop [this message]
2009-02-25 3:53 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902241813.02252.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=akpm@linux-foundation.org \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=jplatte@naasa.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
--cc=mjg59@srcf.ucam.org \
--cc=ott@mirix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox