From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-kernel@vger.kernel.org, vegard.nossum@gmail.com,
mingo@elte.hu, stable@kernel.org, akpm@linux-foundation.org,
penberg@cs.helsinki.fi
Subject: Re: [PATCH] v3 Teach RCU that idle task is not quiscent state at boot
Date: Tue, 24 Feb 2009 20:43:56 -0800 [thread overview]
Message-ID: <20090225044356.GD7241@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090225041259.GA14149@wotan.suse.de>
On Wed, Feb 25, 2009 at 05:12:59AM +0100, Nick Piggin wrote:
> Looks OK to me. It's a bit "theoretically" displeasing that
> you still treat synchronize_rcu as a gp even after we spawn
> some kernel threads.
>
> ... but it probably isn't worth trying to rearrange the boot
> code just to make this look better. I can't see any actual
> problems that could arise, as the threads should not have
> had a chance to run yet.
And if rcuclassic or rcutree on a UP system, even if threads have had
a chance to run, it is OK to treat synchronize_rcu() as a grace period,
since it has the opportunity to block.
> I wonder if you couldn't put in a WARN_ON(nr_context_switches() > 0)
> in rcu_idle_now_means_idle() just in case?
Makes a lot of sense -- updated and am firing off the tests!
Thanx, Paul
> On Tue, Feb 24, 2009 at 04:29:37PM -0800, Paul E. McKenney wrote:
> > This patch fixes a bug located by Vegard Nossum with the aid of
> > kmemcheck, updated based on review comments from Nick Piggin,
> > Ingo Molnar, and Andrew Morton.
next prev parent reply other threads:[~2009-02-25 4:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 16:16 [PATCH] Teach RCU that idle task is not quiscent state at boot Paul E. McKenney
2009-02-23 17:13 ` Ingo Molnar
2009-02-23 20:43 ` [PATCH] v2 " Paul E. McKenney
2009-02-24 4:02 ` Nick Piggin
2009-02-24 5:08 ` Paul E. McKenney
2009-02-24 14:50 ` Paul E. McKenney
2009-02-25 0:29 ` [PATCH] v3 " Paul E. McKenney
2009-02-25 4:12 ` Nick Piggin
2009-02-25 4:43 ` Paul E. McKenney [this message]
2009-02-25 14:19 ` [PATCH] v4 " Paul E. McKenney
2009-02-25 16:00 ` Ingo Molnar
2009-02-25 16:26 ` Nick Piggin
2009-02-25 17:12 ` Paul E. McKenney
2009-02-25 17:18 ` Nick Piggin
2009-02-25 17:36 ` Paul E. McKenney
2009-02-25 17:08 ` Paul E. McKenney
2009-02-26 3:09 ` Ingo Molnar
2009-02-25 18:38 ` Vegard Nossum
2009-02-25 19:01 ` Paul E. McKenney
2009-02-26 2:03 ` [PATCH] v5 " Paul E. McKenney
2009-02-26 3:08 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225044356.GD7241@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=penberg@cs.helsinki.fi \
--cc=stable@kernel.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).