public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Theodore Tso <tytso@mit.edu>,
	Arjan van de Ven <arjan@infradead.org>,
	Pekka Paalanen <pq@iki.fi>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Jason Baron <jbaron@redhat.com>, Martin Bligh <mbligh@google.com>,
	Mathieu Desnoyers <compudj@krystal.dyndns.org>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Masami Hiramatsu <mhiramat@redhat.com>,
	Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH] tracing: remove /debug/tracing/latency_trace
Date: Wed, 25 Feb 2009 11:07:26 +0100	[thread overview]
Message-ID: <20090225100726.GD12352@elte.hu> (raw)
In-Reply-To: <1235554387.3849.30.camel@penberg-laptop>


* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> Hi Andrew,
> 
> On Wed, 2009-02-25 at 01:22 -0800, Andrew Morton wrote:
> > irqsoff latency trace v1.1.5 on 2.6.26-rc8
> > --------------------------------------------------------------------
> >  latency: 97 us, #3/3, CPU#0 | (M:preempt VP:0, KP:0, SP:0 HP:0 #P:2)
> >     -----------------
> >     | task: swapper-0 (uid:0 nice:0 policy:0 rt_prio:0)
> >     -----------------
> >  => started at: apic_timer_interrupt
> >  => ended at:   do_softirq
> 
> <the header seems broken here, should have # at the beginning 
> of the line>

yep.

Furthermore note that latency_trace is a legacy format which i 
think we'll deprecate - in fact see the patch below. The primary 
format that people use is /debug/tracing/trace.

All the pretty-printing patches that Andrew has seen and 
complained about affect /debug/tracing/trace, not 
/debug/tracing/latency_trace.

	Ingo

----------------->
>From 886b5b73d71e4027d7dc6c14f5f7ab102201ea6b Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 25 Feb 2009 11:03:44 +0100
Subject: [PATCH] tracing: remove /debug/tracing/latency_trace

Impact: remove old debug/tracing API

/debug/tracing/latency_trace is an old legacy format we kept from
the old latency tracer. Remove the file for now. If there's any
useful bit missing then we'll propagate any useful output bits into
the /debug/tracing/trace output.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/trace/trace.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index e1f3b99..11ba100 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2938,11 +2938,6 @@ static __init int tracer_init_debugfs(void)
 	if (!entry)
 		pr_warning("Could not create debugfs 'tracing_cpumask' entry\n");
 
-	entry = debugfs_create_file("latency_trace", 0444, d_tracer,
-				    &global_trace, &tracing_lt_fops);
-	if (!entry)
-		pr_warning("Could not create debugfs 'latency_trace' entry\n");
-
 	entry = debugfs_create_file("trace", 0444, d_tracer,
 				    &global_trace, &tracing_fops);
 	if (!entry)

  parent reply	other threads:[~2009-02-25 10:08 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25  2:56 [PATCH 0/4] [git pull] tip/tracing/ftrace Steven Rostedt
2009-02-25  2:56 ` [PATCH 1/4] tracing: add DEFINE_TRACE_FMT to tracepoint.h Steven Rostedt
2009-02-25  6:27   ` Peter Zijlstra
2009-02-25 13:01     ` Steven Rostedt
2009-02-25 16:09       ` Mathieu Desnoyers
2009-02-25 16:13   ` Mathieu Desnoyers
2009-02-25 16:28     ` Steven Rostedt
2009-02-25 16:33       ` Ingo Molnar
2009-02-25  2:56 ` [PATCH 2/4] tracing: add event trace infrastructure Steven Rostedt
2009-02-25  3:45   ` Andrew Morton
2009-02-25  4:08     ` Steven Rostedt
2009-02-25  4:24       ` Nick Piggin
2009-02-25  4:33       ` Andrew Morton
2009-02-25  5:16         ` Mathieu Desnoyers
2009-02-25  8:11         ` Ingo Molnar
2009-02-25  8:28           ` Andrew Morton
2009-02-25  8:40             ` Ingo Molnar
2009-02-25  9:15               ` Andrew Morton
2009-02-25  9:00             ` Pekka Enberg
2009-02-25  9:10               ` Ingo Molnar
2009-02-25  9:22               ` Andrew Morton
2009-02-25  9:26                 ` Peter Zijlstra
2009-02-25 10:31                   ` Ingo Molnar
2009-02-25  9:33                 ` Pekka Enberg
2009-02-25  9:44                   ` Andrew Morton
2009-02-25  9:56                     ` Ingo Molnar
2009-02-25 10:02                       ` Andrew Morton
2009-02-25 10:24                         ` Pekka Enberg
2009-02-25 10:27                         ` Ingo Molnar
2009-02-25 16:21                       ` Frederic Weisbecker
2009-02-25  9:57                     ` Pekka Enberg
2009-02-25 10:07                   ` Ingo Molnar [this message]
2009-02-25 14:41                 ` Steven Rostedt
2009-02-25 15:57                   ` Ingo Molnar
2009-02-25 16:09                     ` Steven Rostedt
2009-02-25 22:48                     ` Steven Rostedt
2009-02-26  3:19                       ` Ingo Molnar
2009-02-25 13:54             ` Theodore Tso
2009-02-26 21:08               ` Frank Ch. Eigler
2009-03-01 10:37             ` KOSAKI Motohiro
2009-02-25 13:37     ` Theodore Tso
2009-02-25 14:10       ` Steven Rostedt
2009-02-25  9:07   ` Lai Jiangshan
2009-02-25 13:50     ` Steven Rostedt
2009-02-25  9:21   ` Lai Jiangshan
2009-02-25 13:54     ` Steven Rostedt
2009-02-25  2:56 ` [PATCH 3/4] tracing: add schedule events to event trace Steven Rostedt
2009-02-25  6:29   ` Peter Zijlstra
2009-02-25  2:56 ` [PATCH 4/4] tracing: make event directory structure Steven Rostedt
2009-02-25  6:59   ` Frederic Weisbecker
2009-02-25 13:07     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090225100726.GD12352@elte.hu \
    --to=mingo@elte.hu \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=compudj@krystal.dyndns.org \
    --cc=fche@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=jbaron@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@google.com \
    --cc=mhiramat@redhat.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=peterz@infradead.org \
    --cc=pq@iki.fi \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox