From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
peterz@infradead.org, fweisbec@gmail.com, srostedt@redhat.com
Subject: Re: [PATCH 1/4] uaccess: add copy_word_from_user
Date: Wed, 25 Feb 2009 15:56:48 -0800 [thread overview]
Message-ID: <20090225155648.acb93cff.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090225203427.382137706@goodmis.org>
btw,
On Wed, 25 Feb 2009 15:30:08 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> +int copy_word_from_user(void *to, const void __user *from,
> + unsigned int copy, unsigned int read,
> + unsigned int *copied, int skip)
You presently have this not-exported-to-modules. Was that deliberate?
There are arguments either way. Lately we've tended to take the
position that a whole interface either is or is not wholly exported.
The uaccess functions are exported, so this one should be as well.
We can of course do that later on, when there's a user - I have no
particular preference personally.
<looks at probe_kernel_read and probe_kernel_write>
These are really part of the uaccess interface too. I don't see a need
for both lib/uaccess.c and mm/maccess.c?
probe_kernel_read() and probe_kernel_write() are EXPORT_SYMBOL_GPL,
whereas the rest of the uaccess interface is EXPORT_SYMBOL. Ho hum.
next prev parent reply other threads:[~2009-02-25 23:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 20:30 [PATCH 0/4] [git pull] for tip/tracing/ftrace Steven Rostedt
2009-02-25 20:30 ` [PATCH 1/4] uaccess: add copy_word_from_user Steven Rostedt
2009-02-25 21:39 ` Andrew Morton
2009-02-25 22:00 ` Steven Rostedt
2009-02-25 22:18 ` [PATCH][git pull] uaccess: add example to copy_word_from_user in comment Steven Rostedt
2009-02-25 21:40 ` [PATCH 1/4] uaccess: add copy_word_from_user Frederic Weisbecker
2009-02-25 21:54 ` Andrew Morton
2009-02-25 23:56 ` Andrew Morton [this message]
2009-02-26 1:46 ` Steven Rostedt
2009-02-26 5:34 ` Andrew Morton
2009-02-26 2:02 ` H. Peter Anvin
2009-02-26 2:10 ` Frederic Weisbecker
2009-02-26 2:13 ` H. Peter Anvin
2009-02-26 2:17 ` Steven Rostedt
2009-02-26 2:18 ` H. Peter Anvin
2009-02-26 5:36 ` Andrew Morton
2009-02-26 5:43 ` Steven Rostedt
2009-02-25 20:30 ` [PATCH 2/4] tracing: convert event_trace to use copy_word_from_user Steven Rostedt
2009-02-25 20:30 ` [PATCH 3/4] tracing: convert ftrace_regex_write " Steven Rostedt
2009-02-25 20:30 ` [PATCH 4/4] tracing: convert ftrace_graph_write " Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225155648.acb93cff.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox