From: Greg KH <gregkh@suse.de>
To: Frank Seidel <fseidel@suse.de>
Cc: Thiago Galesi <thiagogalesi@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux kernel <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org, Frank Seidel <frank@f-seidel.de>,
akpm@linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
nhorman@tuxdriver.com, lho@amcc.com, kaber@trash.net,
darrenrjenkins@gmail.com
Subject: Re: [PATCH][trivial] crypto: tcrypt - reduce stack size
Date: Wed, 25 Feb 2009 11:40:13 -0800 [thread overview]
Message-ID: <20090225194013.GB6193@suse.de> (raw)
In-Reply-To: <49A556E3.1000309@suse.de>
On Wed, Feb 25, 2009 at 03:34:11PM +0100, Frank Seidel wrote:
> Thiago Galesi wrote:
> > If you write static char output[1024]; (even inside a function) it's
> > not allocated on the stack.
>
> Oh, yes i misunderstood Herbert, sorry. But anyway isn't
> it preferred to kmalloc such arrays?
> Greg, i thought it was you who told me so, is that right?
Generally, yes, it is preferred. But if it can be static, that's fine
too.
thanks,
greg k-h
next prev parent reply other threads:[~2009-02-25 19:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 13:48 [PATCH][trivial] crypto: tcrypt - reduce stack size Frank Seidel
2009-02-25 14:06 ` Thiago Galesi
2009-02-25 14:06 ` Neil Horman
2009-02-25 14:20 ` Herbert Xu
2009-02-25 14:24 ` Frank Seidel
2009-02-25 14:27 ` Herbert Xu
2009-02-25 14:31 ` Geert Uytterhoeven
2009-02-25 14:36 ` Frank Seidel
2009-02-25 14:44 ` Geert Uytterhoeven
2009-02-25 14:54 ` Frank Seidel
2009-02-25 14:29 ` Thiago Galesi
2009-02-25 14:34 ` Frank Seidel
2009-02-25 19:40 ` Greg KH [this message]
2009-02-25 14:24 ` [PATCHv2][trivial] " Frank Seidel
2009-02-25 14:53 ` [PATCHv3][trivial] " Frank Seidel
2009-02-25 15:32 ` Neil Horman
2009-03-29 7:19 ` Herbert Xu
2009-02-25 15:54 ` Geert Uytterhoeven
2009-02-25 15:56 ` Frank Seidel
2009-02-25 15:58 ` Geert Uytterhoeven
2009-02-25 16:01 ` Frank Seidel
2009-02-25 16:08 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090225194013.GB6193@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=darrenrjenkins@gmail.com \
--cc=davem@davemloft.net \
--cc=frank@f-seidel.de \
--cc=fseidel@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=lho@amcc.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=thiagogalesi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox