Re: [PATCH] make CALLER_ADDRx overwriteable

KOSAKI Motohiro
2009-02-28T06:41:59Z

> The current definition of CALLER_ADDRx isn't suitable for all platforms.
> E.g. for ARM __builtin_return_address(N) doesn't work for N > 0 and
> AFAIK for powerpc there are no frame pointers needed to have a working
> __builtin_return_address. This patch allows defining the CALLER_ADDRx
> macros in <asm/ftrace.h> and let these take precedence.
>
> Because now <asm/ftrace.h> is included unconditionally in
> <linux/ftrace.h> all archs that don't already had this include get an
> empty one for free.
>
> Signed-off-by: Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> --
> Hello,
>
> OK, changed to check for HAVE_ARCH_CALLER_ADDR instead of CALLER_ADDR0.
>
> Best regards
> Uwe

thanks.

Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>