From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Harvey Harrison <harvey.harrison@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] introduce pr_cont macro
Date: Thu, 26 Feb 2009 12:31:00 +0300 [thread overview]
Message-ID: <20090226093100.GB8111@localhost> (raw)
In-Reply-To: <49A62899.4080001@zytor.com>
[H. Peter Anvin - Wed, Feb 25, 2009 at 09:28:57PM -0800]
> Ingo Molnar wrote:
>>
>> Btw., why do those macros use ##__VA_ARGS__ ? Why not a
>> straightforward:
>>
>> #define __pr_cont(args...) \
>> printk(KERN_CONT args)
>>
>
> Don't know if anyone cares, but __VA_ARGS__ is C99 whereas args... is a
> gcc extension, AFAIK.
>
> -hpa
>
This one should be fine.
- Cyrill -
---
Subject: [PATCH] introduce pr_cont macro v2
We cover all log-levels by pr_... macros except
KERN_CONT one. Add it for convenience.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
Using 'fmt' here make this macro look similar
to others (same missioned) macros. Which is
good :)
include/linux/kernel.h | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.git/include/linux/kernel.h
===================================================================
--- linux-2.6.git.orig/include/linux/kernel.h
+++ linux-2.6.git/include/linux/kernel.h
@@ -370,6 +370,8 @@ static inline char *pack_hex_byte(char *
printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
#define pr_info(fmt, ...) \
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
+#define pr_cont(fmt, ...) \
+ printk(KERN_CONT fmt, ##__VA_ARGS__)
/* If you are writing a driver, please use dev_dbg instead */
#if defined(DEBUG)
prev parent reply other threads:[~2009-02-26 9:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 20:59 [RFC] introduce pr_cont macro Cyrill Gorcunov
2009-02-26 3:03 ` Ingo Molnar
2009-02-26 3:05 ` Harvey Harrison
2009-02-26 3:13 ` Ingo Molnar
2009-02-26 3:22 ` Harvey Harrison
2009-02-26 3:25 ` Ingo Molnar
2009-02-26 4:04 ` Cyrill Gorcunov
2009-02-26 5:25 ` Cyrill Gorcunov
2009-02-26 5:28 ` H. Peter Anvin
2009-02-26 6:51 ` Cyrill Gorcunov
2009-02-26 9:31 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226093100.GB8111@localhost \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox