From: Ingo Molnar <mingo@elte.hu>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] perfcounters: fix a few minor cleanliness issues
Date: Thu, 26 Feb 2009 13:04:11 +0100 [thread overview]
Message-ID: <20090226120411.GA10479@elte.hu> (raw)
In-Reply-To: <18854.33125.115592.732783@cargo.ozlabs.ibm.com>
* Paul Mackerras <paulus@samba.org> wrote:
> This fixes three issues noticed by Arnd Bergmann:
>
> - Add #ifdef __KERNEL__ and move some things around in perf_counter.h
> to make sure only the bits that userspace needs are exported to
> userspace.
>
> - Use __u64, __s64, __u32 types in the structs exported to userspace
> rather than u64, s64, u32.
>
> - Make the sys_perf_counter_open syscall available to the SPUs on
> Cell platforms.
>
> And one issue that I noticed in looking at the code again:
>
> - Wrap the perf_counter_open syscall with SYSCALL_DEFINE4 so we get
> the proper handling of int arguments on ppc64 (and some other 64-bit
> architectures).
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
> ---
> This is in the master branch of my perfcounters.git tree at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/paulus/perfcounters.git master
>
> arch/powerpc/include/asm/systbl.h | 2 +-
> include/linux/perf_counter.h | 43 +++++++++++++++++++-----------------
> include/linux/syscalls.h | 9 ++-----
> kernel/perf_counter.c | 6 ++--
> 4 files changed, 30 insertions(+), 30 deletions(-)
Pulled into tip:perfcounters/core, thanks Paul!
Ingo
next prev parent reply other threads:[~2009-02-26 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 11:47 [PATCH] perfcounters: fix a few minor cleanliness issues Paul Mackerras
2009-02-26 12:04 ` Ingo Molnar [this message]
2009-02-26 13:42 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226120411.GA10479@elte.hu \
--to=mingo@elte.hu \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox