From: David Brownell <david-b@pacbell.net>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Mark Brown <broonie@sirena.org.uk>,
lkml <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org, OMAP <linux-omap@vger.kernel.org>,
Kalle Jokiniemi <kalle.jokiniemi@digia.com>
Subject: Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged
Date: Thu, 26 Feb 2009 14:40:03 -0800 [thread overview]
Message-ID: <200902261440.04129.david-b@pacbell.net> (raw)
In-Reply-To: <1235686596.31223.106.camel@vega.slimlogic.co.uk>
On Thursday 26 February 2009, Liam Girdwood wrote:
> On Sun, 2009-02-08 at 10:52 -0800, David Brownell wrote:
> > From: Kalle Jokiniemi <kalle.jokiniemi@digia.com>
> >
> > This patch disables LDO regulators VUSB1V5, VUSB1V8, and VUSB3V1
> > when the USB cable is unplugged, to eliminate that source of power
> > waste. (Enabled LDOs consume power at all times.)
> >
> > Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@digia.com>
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> > ---
> > Depends on the twl4030 regulator driver, so I'm suggesting this
> > be merged (with that driver) through the regulator patch queue
> > to simplify things.
> >
> > drivers/usb/otg/twl4030-usb.c | 30 ++++++++++++++++++++++++------
> > 1 file changed, 24 insertions(+), 6 deletions(-)
>
> Applied.
Better suggestion: grab Kalle's updated patch from Greg's USB
queue:
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-04-usb/
patch name usb-twl-disable-vusb-regulators-when-cable-unplugged.patch
- Dave
next prev parent reply other threads:[~2009-02-26 22:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 18:52 [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged David Brownell
2009-02-10 13:08 ` Kalle Jokiniemi
2009-02-10 15:19 ` Mark Brown
2009-02-10 14:06 ` Kalle Jokiniemi
2009-02-26 22:16 ` Liam Girdwood
2009-02-26 22:40 ` David Brownell [this message]
2009-02-27 6:19 ` Kalle Jokiniemi
2009-02-27 12:29 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902261440.04129.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=broonie@sirena.org.uk \
--cc=kalle.jokiniemi@digia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox