From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] make CALLER_ADDRx overwriteable
Date: Fri, 27 Feb 2009 12:22:34 +0100 [thread overview]
Message-ID: <20090227112234.GA27221@pengutronix.de> (raw)
In-Reply-To: <20090227161302.1551.A69D9226@jp.fujitsu.com>
Hi,
On Fri, Feb 27, 2009 at 04:32:45PM +0900, KOSAKI Motohiro wrote:
> > -#ifdef CONFIG_FRAME_POINTER
> > -/* TODO: need to fix this for ARM */
> > -# define CALLER_ADDR0 ((unsigned long)__builtin_return_address(0))
> > -# define CALLER_ADDR1 ((unsigned long)__builtin_return_address(1))
> > -# define CALLER_ADDR2 ((unsigned long)__builtin_return_address(2))
> > -# define CALLER_ADDR3 ((unsigned long)__builtin_return_address(3))
> > -# define CALLER_ADDR4 ((unsigned long)__builtin_return_address(4))
> > -# define CALLER_ADDR5 ((unsigned long)__builtin_return_address(5))
> > -# define CALLER_ADDR6 ((unsigned long)__builtin_return_address(6))
> > -#else
> > -# define CALLER_ADDR0 ((unsigned long)__builtin_return_address(0))
> > -# define CALLER_ADDR1 0UL
> > -# define CALLER_ADDR2 0UL
> > -# define CALLER_ADDR3 0UL
> > -# define CALLER_ADDR4 0UL
> > -# define CALLER_ADDR5 0UL
> > -# define CALLER_ADDR6 0UL
> > -#endif
> > +#ifndef CALLER_ADDR0
>
> but I think this "#ifndef CALLER_ADDR0" don't explain developer intention at all.
> ARCH_HAS_XXXXX macro is better?
OK, this seems clearer. I'd use HAVE_ARCH_CALLER_ADDR though.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2009-02-27 11:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 22:16 [PATCH] make CALLER_ADDRx overwriteable Uwe Kleine-König
2009-02-25 22:20 ` Mike Frysinger
2009-02-25 22:26 ` Uwe Kleine-König
2009-02-26 5:08 ` Steven Rostedt
2009-02-26 13:45 ` Uwe Kleine-König
2009-02-26 13:59 ` Steven Rostedt
2009-02-26 22:11 ` Uwe Kleine-König
2009-02-27 7:32 ` KOSAKI Motohiro
2009-02-27 11:22 ` Uwe Kleine-König [this message]
2009-02-27 15:21 ` Steven Rostedt
2009-02-27 20:30 ` Uwe Kleine-König
2009-02-28 6:40 ` KOSAKI Motohiro
2009-02-28 7:25 ` Uwe Kleine-König
[not found] <1235594749-24585-1-git-send-email-u.kleine-koenig@pengutronix.de>
2009-02-26 3:02 ` Ingo Molnar
2009-02-26 3:13 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090227112234.GA27221@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox