Re: [PATCH 1/2] input: misc: add twl4030-pwrbutton driver

Dmitry Torokhov
2009-03-04T09:00:56Z

On Sun, Mar 01, 2009 at 04:40:19PM +0200, Felipe Balbi wrote:
> On Sat, Feb 28, 2009 at 04:58:01PM -0800, Dmitry Torokhov wrote:
> > On Sun, Mar 01, 2009 at 02:30:18AM +0200, Felipe Balbi wrote:
> > > On Sat, Feb 28, 2009 at 02:23:03PM -0800, Dmitry Torokhov wrote:
> > > > Hi Felipe,
> > > >
> > > > On Fri, Feb 27, 2009 at 09:28:02PM +0200, Felipe Balbi wrote:
> > > > > From: Felipe Balbi <felipe.balbi@nokia.com>
> > > > >
> > > > > This is part of the twl4030 multifunction device driver.
> > > > >
> > > > > With this driver we add support for reporting KEY_POWER
> > > > > events via the input layer.
> > > >
> > > > ...
> > >
> > > thanks for reviewing, how about the version below:
> > >
> >
> > Looks good, couple more items...
>
> Fixed the extra comments and also got rid of the global input_dev
> structure. It could be fetched by passing it to request_irq() and
> platform_set/get_drvdata():
>

Cool, I will keep it in my tree pending the threaded IRQ issue
resolution.

--
Dmitry