Re: [PATCH 2/2] mfd: twl4030: add twl4030-pwrbutton as our child

David Brownell
2009-02-27T23:21:17Z

On Friday 27 February 2009, Andrew Morton wrote:
> > >
> > > What has gone wrong here?
> >
> > Not much I can see.  It's registering a platform_device,
> > but only if it could be used on this system.
>
> Again, that all gets fixed if this is done the right way around.  Run
> your probe function.  If the hardware is there, register with the core
> and all the nodes appear.  If the hardware is not present: bale.

Right. If there's no button hooked up to its "power button"
signal, don't register that "twl4030-pwrbutton" node.

> The design of the whole subsystem appears to be upside down :(

You seem to be missing something. Is it only the lack of that
tweak Felipe sent?