Re: [PATCH 2/4] zedtrace generic kernel filtering

[Ingo Molnar <mingo@elte.hu>]

* Tom Zanussi <tzanussi@gmail.com> wrote:

> Add generic kernel filtering.
> 
> Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
> 
> ---
>  kernel/trace/trace_binary/Makefile     |    2 +-
>  kernel/trace/trace_binary/zed.c        |  103 +++++++++--
>  kernel/trace/trace_binary/zed.h        |   15 ++
>  kernel/trace/trace_binary/zed_filter.c |  301 ++++++++++++++++++++++++++++++++
>  kernel/trace/trace_binary/zed_filter.h |   45 +++++
>  kernel/trace/trace_binary/zed_sched.c  |    4 +
>  6 files changed, 451 insertions(+), 19 deletions(-)
>  create mode 100644 kernel/trace/trace_binary/zed_filter.c
>  create mode 100644 kernel/trace/trace_binary/zed_filter.h

Nice!

This fits really nicely into the ftrace principles and i'd love 
to see this feature merged into ftrace - would you be interested 
in working on that? If so then you can find the latest tracing 
tree at:

    http://people.redhat.com/mingo/tip.git/README

Note that Steve added explicit field enumeration and 'raw' C 
syntax tracepoints to the event tracer earlier today (partly 
based on your ideas here), so that would be a good basis to 
extend/enhance/fix, if you are interested.

Thanks,

	Ingo