From: Mark Brown <broonie@sirena.org.uk>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on empty commit log bodies
Date: Sat, 28 Feb 2009 17:52:20 +0000 [thread overview]
Message-ID: <20090228175218.GA4606@sirena.org.uk> (raw)
In-Reply-To: <49A97563.6040906@s5r6.in-berlin.de>
On Sat, Feb 28, 2009 at 06:33:23PM +0100, Stefan Richter wrote:
> This really surprises me. ^Subject: .+$ is the title of the log and
> thereby its first part. Also, I don't see a connection to git. I
> manage patches with quilt and never loose patch titles. I still think
> you should count ^Subject: .+$ too if you want to check for presence of
> a changelog.
I believe the issue is the UI of a MUA - the subject line of a mail is
normally presented separately to the body and isn't always as
immediately prominent as the body so it's harder work to look at it.
This is sensible for e-mail since the general style is that the subject
line shouldn't be required in order to comprehend what the message is
about but that's exactly what's happening when a one line changelog is
e-mailed.
The connection with git is that it doesn't really draw a similar
distinction so the issue isn't as immediately obvious when you're
working within it.
next prev parent reply other threads:[~2009-02-28 17:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 18:05 [PATCH] checkpatch: Warn on empty commit log bodies Mark Brown
2009-02-28 13:58 ` Stefan Richter
2009-02-28 15:58 ` Mark Brown
2009-02-28 16:14 ` Stefan Richter
2009-02-28 16:46 ` Mark Brown
2009-02-28 17:33 ` Stefan Richter
2009-02-28 17:52 ` Mark Brown [this message]
2009-02-28 19:25 ` Stefan Richter
2009-02-28 21:02 ` Mark Brown
2009-02-28 23:01 ` Stefan Richter
2009-03-01 0:18 ` Theodore Tso
2009-03-01 0:46 ` Mark Brown
2009-03-01 2:53 ` Theodore Tso
2009-03-02 13:15 ` Mark Brown
2009-03-02 15:15 ` Stefan Richter
2009-03-02 16:01 ` Mark Brown
2009-03-02 18:01 ` Andrew Morton
2009-03-02 18:24 ` Mark Brown
2009-03-02 18:34 ` Andrew Morton
2009-03-02 18:43 ` Theodore Tso
2009-03-02 19:19 ` Mark Brown
2009-03-02 19:57 ` Theodore Tso
2009-03-02 20:38 ` Mark Brown
2009-03-10 18:19 ` Andy Whitcroft
2009-02-28 17:40 ` Arjan van de Ven
2009-02-28 17:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090228175218.GA4606@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox